Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encode targets for Time Series Classification Pipelines #2040

Merged
merged 5 commits into from Mar 26, 2021

Conversation

freddyaboulton
Copy link
Contributor

Pull Request Description

Fixes #1976


After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of docs/source/release_notes.rst to include this pull request by adding :pr:123.

@freddyaboulton freddyaboulton changed the title Encode target for ts classification. Encode targets for Time Series Classification Pipelines Mar 25, 2021
@freddyaboulton freddyaboulton force-pushed the 1976-encode-target-ts-pipelines branch from f8bebda to d7d964b Compare March 25, 2021 20:33
@codecov
Copy link

codecov bot commented Mar 25, 2021

Codecov Report

Merging #2040 (f3ec5f5) into main (77b528b) will decrease coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             main    #2040     +/-   ##
=========================================
- Coverage   100.0%   100.0%   -0.0%     
=========================================
  Files         278      278             
  Lines       22920    22770    -150     
=========================================
- Hits        22911    22761    -150     
  Misses          9        9             
Impacted Files Coverage Δ
.../pipelines/time_series_classification_pipelines.py 100.0% <100.0%> (ø)
evalml/tests/pipeline_tests/test_pipelines.py 100.0% <100.0%> (ø)
...peline_tests/test_time_series_baseline_pipeline.py 100.0% <100.0%> (ø)
.../tests/pipeline_tests/test_time_series_pipeline.py 100.0% <100.0%> (ø)
...lml/tests/model_understanding_tests/test_graphs.py 100.0% <0.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77b528b...f3ec5f5. Read the comment docs.

Copy link
Contributor

@bchen1116 bchen1116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Can you add a test for thresholding the binary TS pipeline? As per issue, "then adding in an equivalent test as test_binary_pipeline_string_target_thresholding in test_pipelines to the time_series_pipeline tests."

Otherwise, looks good to me!

@CLAassistant
Copy link

CLAassistant commented Mar 26, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@ParthivNaresh ParthivNaresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Nice mocking work

@freddyaboulton freddyaboulton force-pushed the 1976-encode-target-ts-pipelines branch from d7d964b to ad29895 Compare March 26, 2021 15:10
@freddyaboulton freddyaboulton force-pushed the 1976-encode-target-ts-pipelines branch from 844a765 to 74704a1 Compare March 26, 2021 17:15
@freddyaboulton
Copy link
Contributor Author

@bchen1116 Great call! Just pushed up that test.

Copy link
Contributor

@chukarsten chukarsten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, love the tests too. I dunno what it is about a good test that I can look at the name of and read and see it do what it set out to do that makes me feel good, but it does. I added a note about maybe parameterizing your for loop to make test failures a little prettier, but take it or leave it.

Comment on lines 1986 to 1987
for pipeline_class in [time_series_binary_classification_pipeline_class,
logistic_regression_binary_pipeline_class]:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be a nit, but it'll look better in test failure, perhaps paratetrize this one?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call! I just got lazy cause you can't parametrize over fixtures lol

@freddyaboulton freddyaboulton merged commit cb89ebf into main Mar 26, 2021
@freddyaboulton freddyaboulton deleted the 1976-encode-target-ts-pipelines branch March 26, 2021 21:38
@chukarsten chukarsten mentioned this pull request Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix TS Pipelines to encode target data for both predict and predict_proba
5 participants