Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Oversampler components to EvalML #2079

Merged
merged 57 commits into from
Apr 21, 2021
Merged

Add Oversampler components to EvalML #2079

merged 57 commits into from
Apr 21, 2021

Conversation

bchen1116
Copy link
Contributor

@bchen1116 bchen1116 commented Apr 2, 2021

fix #2014

Design doc here

Example code to show the oversampler works in pipelines:
image

@bchen1116 bchen1116 self-assigned this Apr 2, 2021
@codecov
Copy link

codecov bot commented Apr 2, 2021

Codecov Report

Merging #2079 (7a3a7af) into main (027f877) will increase coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             main    #2079     +/-   ##
=========================================
+ Coverage   100.0%   100.0%   +0.1%     
=========================================
  Files         293      295      +2     
  Lines       24056    24362    +306     
=========================================
+ Hits        24046    24352    +306     
  Misses         10       10             
Impacted Files Coverage Δ
evalml/pipelines/components/__init__.py 100.0% <ø> (ø)
...alml/pipelines/components/transformers/__init__.py 100.0% <100.0%> (ø)
...lines/components/transformers/samplers/__init__.py 100.0% <100.0%> (ø)
...s/components/transformers/samplers/base_sampler.py 100.0% <100.0%> (ø)
...s/components/transformers/samplers/oversamplers.py 100.0% <100.0%> (ø)
evalml/pipelines/components/utils.py 100.0% <100.0%> (ø)
evalml/tests/component_tests/test_components.py 100.0% <100.0%> (ø)
evalml/tests/component_tests/test_oversamplers.py 100.0% <100.0%> (ø)
evalml/tests/component_tests/test_utils.py 100.0% <100.0%> (ø)
evalml/tests/pipeline_tests/test_pipelines.py 100.0% <100.0%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 027f877...7a3a7af. Read the comment docs.

@bchen1116 bchen1116 marked this pull request as ready for review April 5, 2021 18:15
@bchen1116
Copy link
Contributor Author

Filed an issue to track incorporating dictionary to oversamplers here. I will remove support for accepting dictionary input for now!

Copy link
Contributor

@chukarsten chukarsten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good changes! Good work!

Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bchen1116 I think this is fantastic! Thanks for making the changes 😄

@bchen1116 bchen1116 dismissed dsherry’s stale review April 21, 2021 18:53

Addressed the comments

@bchen1116 bchen1116 merged commit 04959d4 into main Apr 21, 2021
This was referenced May 4, 2021
@freddyaboulton freddyaboulton deleted the bc_oversampler_component branch May 13, 2022 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Oversampling Support: Add Oversampler component to EvalML
4 participants