Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow precision-recall to handle 2d predicted probabilities; docs updates #2090

Merged
merged 20 commits into from Apr 27, 2021

Conversation

dsherry
Copy link
Contributor

@dsherry dsherry commented Apr 5, 2021

Changes:

  • Minor fix to precision-recall graph method: use same code as ROC method to process input data
  • User guide updates: train_pipelines/score_pipelines, automl and pipeline save/load (fix Add user guide entry for pipeline save/load methods #2083 ), move DT viz lower in model understanding guide. Update automl guide to use training-holdout split.
  • Add note to contributers guide about GitHub Actions permissions
  • Fix typo in PipelineBase error.

@codecov
Copy link

codecov bot commented Apr 6, 2021

Codecov Report

Merging #2090 (d6dc364) into main (1cb0724) will increase coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             main    #2090     +/-   ##
=========================================
+ Coverage   100.0%   100.0%   +0.1%     
=========================================
  Files         296      296             
  Lines       24677    24712     +35     
=========================================
+ Hits        24659    24694     +35     
  Misses         18       18             
Impacted Files Coverage Δ
evalml/exceptions/__init__.py 100.0% <ø> (ø)
evalml/pipelines/pipeline_base.py 99.7% <ø> (ø)
evalml/exceptions/exceptions.py 100.0% <100.0%> (ø)
evalml/model_understanding/graphs.py 100.0% <100.0%> (ø)
...lml/tests/model_understanding_tests/test_graphs.py 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cb0724...d6dc364. Read the comment docs.

@dsherry dsherry force-pushed the ds_misc_improvements branch 2 times, most recently from da3683a to ac9fa16 Compare April 26, 2021 18:50
@dsherry dsherry changed the title Docs updates, minor fix to graph_precision_recall and graph err msg Allow precision-recall to handle 2d predicted probabilities; docs updates Apr 26, 2021
@dsherry dsherry marked this pull request as ready for review April 26, 2021 22:54
@dsherry dsherry added documentation Improvements or additions to documentation enhancement An improvement to an existing feature. labels Apr 26, 2021
Copy link
Contributor

@chukarsten chukarsten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An approval for this PR, I have given. Ignore the grammar comments, you may.

image

docs/source/user_guide/automl.ipynb Show resolved Hide resolved
docs/source/user_guide/model_understanding.ipynb Outdated Show resolved Hide resolved
"cell_type": "markdown",
"metadata": {},
"source": [
"Now let's train a decision tree on some data."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Begun, the Grammar Wars have.

@dsherry dsherry merged commit 1d5e101 into main Apr 27, 2021
@dsherry dsherry deleted the ds_misc_improvements branch April 27, 2021 21:47
This was referenced May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement An improvement to an existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add user guide entry for pipeline save/load methods
2 participants