Remove warnings in documentation #2097
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2097 +/- ##
=======================================
Coverage 100.0% 100.0%
=======================================
Files 288 288
Lines 23419 23419
=======================================
Hits 23409 23409
Misses 10 10 Continue to review full report at Codecov.
|
bchen1116
changed the title
bchen1116
requested review from
dsherry,
freddyaboulton,
jeremyliweishih,
angela97lin,
christopherbunn and
chukarsten
and removed request for
dsherry
| @@ -0,0 +1,2 @@ | |||
| import warnings | |||
| warnings.filterwarnings('ignore') | |||
There was a problem hiding this comment.
Just thinking out loud... do we want to disable all warnings? Is it possible to disable just DeprecationWarnings? I know warnings in the past have been useful in showing where some things are not as we expected, could be out of scope for this PR though.
There was a problem hiding this comment.
Agree on the idea but I also think it's best suited for a different PR. We'll have to modify deprecate_arg to issue a DeprecationWarning for starters which, although is a small change, seems out of scope for this PR. I think the intent was a refactor without changing behavior.
There was a problem hiding this comment.
Great idea! Filed a new issue here
| @@ -261,6 +263,8 @@ class AccessorMethodDocumenter(AccessorLevelDocumenter, MethodDocumenter): | |||
|
|
|||
|
|
|||
| def setup(app): | |||
| os.makedirs("/home/docs/.ipython/profile_default/startup") | |||
| shutil.copy("disable-warnings.py", "/home/docs/.ipython/profile_default/startup/") | |||
There was a problem hiding this comment.
They let you run arbitrary code on start-up? 😨
There was a problem hiding this comment.
Yep, apparently! This is what the support team suggested
There was a problem hiding this comment.
Let the evil commence!
fix #2011
testing to clean up documentation code
Before:
After:
