Notebook as part of RTD build process#212
Conversation
Codecov Report
@@ Coverage Diff @@
## master #212 +/- ##
==========================================
- Coverage 96.68% 96.56% -0.12%
==========================================
Files 92 92
Lines 2411 2416 +5
==========================================
+ Hits 2331 2333 +2
- Misses 80 83 +3
Continue to review full report at Codecov.
|
kmax12
left a comment
kmax12
left a comment
There was a problem hiding this comment.
just one comment. maybe get a second opinion to make sure it's all set up correctly and catching problems when there is documentation build errors?
jeremyliweishih
requested review from
angela97lin,
christopherbunn,
kmax12 and
rwedge
|
Need to install graphviz after master update. |
angela97lin
left a comment
angela97lin
left a comment
There was a problem hiding this comment.
Minor things I was wondering about but otherwise LGTM :)
| - install_dependencies | ||
| - run: sudo apt update && sudo apt install -y pandoc && sudo apt install -y graphviz | ||
| - run: source test_python/bin/activate ; make -C docs/ html | ||
| - run: ls docs/build/html |
There was a problem hiding this comment.
since I don't know much about rtd: is it necessary to have this line? Will we not catch errors if make fails?
There was a problem hiding this comment.
Just to make sure. Usually sphinx exits with code 0 even though it didn't build anything.
| - checkout | ||
| - install_dependencies | ||
| - run: sudo apt update && sudo apt install -y pandoc && sudo apt install -y graphviz | ||
| - run: source test_python/bin/activate ; make -C docs/ html |
There was a problem hiding this comment.
Would it be helpful to make sure we're removing all old files first? (that is, call make clean or equivalent)?
There was a problem hiding this comment.
Since it's a clean box the old files shouldn't exist.
3 participants
Running notebooks as part of build and made following changes for build time:
Sampled down Fraud demo to 2500 rows.
Made
Explore Search Resultsonly search 5 rows.Can check here:
https://evalml.featurelabs.com/en/rtd_build/
https://readthedocs.com/projects/feature-labs-inc-evalml/builds/
Example CircleCI build:
https://app.circleci.com/jobs/github/FeatureLabs/evalml/4664