Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Specified Date Feature #2155

Merged
merged 4 commits into from Apr 29, 2021
Merged

Conversation

ParthivNaresh
Copy link
Contributor

Addresses #2070

@ParthivNaresh ParthivNaresh self-assigned this Apr 19, 2021
@codecov
Copy link

codecov bot commented Apr 20, 2021

Codecov Report

Merging #2155 (2580bc3) into main (eb7b3db) will increase coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             main    #2155     +/-   ##
=========================================
+ Coverage   100.0%   100.0%   +0.1%     
=========================================
  Files         296      296             
  Lines       24712    24871    +159     
=========================================
+ Hits        24694    24853    +159     
  Misses         18       18             
Impacted Files Coverage Δ
evalml/automl/utils.py 100.0% <ø> (ø)
evalml/preprocessing/utils.py 100.0% <ø> (ø)
...s/prediction_explanations_tests/test_explainers.py 100.0% <ø> (ø)
evalml/utils/gen_utils.py 99.6% <ø> (ø)
evalml/automl/automl_search.py 100.0% <100.0%> (ø)
...omponents/estimators/regressors/arima_regressor.py 100.0% <100.0%> (ø)
.../transformers/preprocessing/datetime_featurizer.py 100.0% <100.0%> (ø)
...rmers/preprocessing/delayed_feature_transformer.py 100.0% <100.0%> (ø)
.../pipelines/time_series_classification_pipelines.py 100.0% <100.0%> (ø)
...valml/pipelines/time_series_regression_pipeline.py 100.0% <100.0%> (ø)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb7b3db...2580bc3. Read the comment docs.

@ParthivNaresh ParthivNaresh marked this pull request as ready for review April 21, 2021 15:32
@ParthivNaresh ParthivNaresh marked this pull request as draft April 21, 2021 16:10
@ParthivNaresh ParthivNaresh marked this pull request as ready for review April 22, 2021 02:06
@ParthivNaresh
Copy link
Contributor Author

If anyone can provide input as to why code coverage is dropping so heavily despite the added tests, that would be great!

@jeremyliweishih
Copy link
Contributor

jeremyliweishih commented Apr 22, 2021

It looks like a bunch of the ARIMA tests and ARIMA itself isn't covered. I think it might be because ARIMA isn't installed properly and we're skipping these tests. If you click into the tests where Core dependencies is false you can see that the ARIMA tests only have 24% coverage.

Screen Shot 2021-04-22 at 10 17 12 AM
Screen Shot 2021-04-22 at 10 18 31 AM

@ParthivNaresh ParthivNaresh marked this pull request as draft April 22, 2021 15:16
@ParthivNaresh ParthivNaresh marked this pull request as ready for review April 22, 2021 15:17
@ParthivNaresh ParthivNaresh marked this pull request as draft April 22, 2021 15:19
@ParthivNaresh ParthivNaresh marked this pull request as ready for review April 23, 2021 15:24
Copy link
Contributor

@bchen1116 bchen1116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just started looking at this. Will get you a better review Monday!

Copy link
Contributor

@bchen1116 bchen1116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! The tests and implementation look solid!

I left a few comments and suggestions on ways to potentially clean up/simplify the code, but nothing blocking.

evalml/tests/automl_tests/test_automl_search_regression.py Outdated Show resolved Hide resolved
evalml/tests/component_tests/test_arima_regressor.py Outdated Show resolved Hide resolved
evalml/tests/component_tests/test_arima_regressor.py Outdated Show resolved Hide resolved
evalml/tests/component_tests/test_arima_regressor.py Outdated Show resolved Hide resolved
evalml/tests/component_tests/test_estimators.py Outdated Show resolved Hide resolved
requirements.txt Show resolved Hide resolved
Copy link
Contributor

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great to me! Just some clarifying questions and suggestions but nothing blocking.

Copy link
Contributor

@chukarsten chukarsten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just going to block until the 112 commits thing is resolved

@ParthivNaresh ParthivNaresh force-pushed the 2070-User-Specified-Date-Feature branch from c5438ff to 68d6483 Compare April 29, 2021 15:24
date_col = X.pop(self.date_column)
elif isinstance(X.index, pd.DatetimeIndex):
X_index_type = infer_feature_types(pd.Series(X.index)).logical_type.type_string
if self.parameters['date_index'] in X.columns:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Placeholder comment here for what happens if self.parameters["date_index"] is None...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There will be a None check in the DataFrame columns, and pandas allows None as a DataFrame column name so I this shouldn't raise any issues

@ParthivNaresh ParthivNaresh merged commit 1ed595e into main Apr 29, 2021
ParthivNaresh added a commit that referenced this pull request Apr 30, 2021
ParthivNaresh added a commit that referenced this pull request Apr 30, 2021
* Revert "User Specified Date Feature (#2155)"

This reverts commit 1ed595e.

* revert release notes
This was referenced May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants