User Specified Date Feature by ParthivNaresh · Pull Request #2155 · alteryx/evalml

ParthivNaresh · 2021-04-19T22:56:24Z

Addresses #2070

codecov · 2021-04-20T03:05:55Z

Codecov Report

Merging #2155 (2580bc3) into main (eb7b3db) will increase coverage by 0.1%.
The diff coverage is 100.0%.

@@            Coverage Diff            @@
##             main    #2155     +/-   ##
=========================================
+ Coverage   100.0%   100.0%   +0.1%     
=========================================
  Files         296      296             
  Lines       24712    24871    +159     
=========================================
+ Hits        24694    24853    +159     
  Misses         18       18

Impacted Files	Coverage Δ
evalml/automl/utils.py	`100.0% <ø> (ø)`
evalml/preprocessing/utils.py	`100.0% <ø> (ø)`
...s/prediction_explanations_tests/test_explainers.py	`100.0% <ø> (ø)`
evalml/utils/gen_utils.py	`99.6% <ø> (ø)`
evalml/automl/automl_search.py	`100.0% <100.0%> (ø)`
...omponents/estimators/regressors/arima_regressor.py	`100.0% <100.0%> (ø)`
.../transformers/preprocessing/datetime_featurizer.py	`100.0% <100.0%> (ø)`
...rmers/preprocessing/delayed_feature_transformer.py	`100.0% <100.0%> (ø)`
.../pipelines/time_series_classification_pipelines.py	`100.0% <100.0%> (ø)`
...valml/pipelines/time_series_regression_pipeline.py	`100.0% <100.0%> (ø)`
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb7b3db...2580bc3. Read the comment docs.

ParthivNaresh · 2021-04-22T02:06:36Z

If anyone can provide input as to why code coverage is dropping so heavily despite the added tests, that would be great!

jeremyliweishih · 2021-04-22T14:17:27Z

It looks like a bunch of the ARIMA tests and ARIMA itself isn't covered. I think it might be because ARIMA isn't installed properly and we're skipping these tests. If you click into the tests where Core dependencies is false you can see that the ARIMA tests only have 24% coverage.

bchen1116

Just started looking at this. Will get you a better review Monday!

bchen1116

This looks good to me! The tests and implementation look solid!

I left a few comments and suggestions on ways to potentially clean up/simplify the code, but nothing blocking.

jeremyliweishih

looks great to me! Just some clarifying questions and suggestions but nothing blocking.

chukarsten

Just going to block until the 112 commits thing is resolved

…n to DatetimeFeaturizer and DelayedFeatureTransformer

chukarsten · 2021-04-28T15:21:42Z

-                date_col = X.pop(self.date_column)
-            elif isinstance(X.index, pd.DatetimeIndex):
+            X_index_type = infer_feature_types(pd.Series(X.index)).logical_type.type_string
+            if self.parameters['date_index'] in X.columns:


Placeholder comment here for what happens if self.parameters["date_index"] is None...

There will be a None check in the DataFrame columns, and pandas allows None as a DataFrame column name so I this shouldn't raise any issues

This reverts commit 1ed595e.

* Revert "User Specified Date Feature (#2155)" This reverts commit 1ed595e. * revert release notes

ParthivNaresh self-assigned this Apr 19, 2021

ParthivNaresh marked this pull request as ready for review April 21, 2021 15:32

ParthivNaresh commented Apr 21, 2021

View reviewed changes

Comment thread evalml/pipelines/components/transformers/preprocessing/delayed_feature_transformer.py

ParthivNaresh marked this pull request as draft April 21, 2021 16:10

ParthivNaresh marked this pull request as ready for review April 22, 2021 02:06

ParthivNaresh requested review from angela97lin, bchen1116, chukarsten, dsherry, freddyaboulton and jeremyliweishih and removed request for freddyaboulton and jeremyliweishih April 22, 2021 02:06

ParthivNaresh marked this pull request as draft April 22, 2021 15:16

ParthivNaresh marked this pull request as ready for review April 22, 2021 15:17

ParthivNaresh marked this pull request as draft April 22, 2021 15:19

ParthivNaresh marked this pull request as ready for review April 23, 2021 15:24

bchen1116 reviewed Apr 23, 2021

View reviewed changes

dsherry reviewed Apr 26, 2021

View reviewed changes

Comment thread .github/workflows/windows_unit_tests.yml Outdated

dsherry reviewed Apr 26, 2021

View reviewed changes

Comment thread evalml/tests/conftest.py

dsherry reviewed Apr 26, 2021

View reviewed changes

Comment thread evalml/pipelines/time_series_classification_pipelines.py

bchen1116 approved these changes Apr 26, 2021

View reviewed changes

jeremyliweishih approved these changes Apr 28, 2021

View reviewed changes

chukarsten suggested changes Apr 28, 2021

View reviewed changes

Single commit

68d6483

ParthivNaresh force-pushed the 2070-User-Specified-Date-Feature branch from c5438ff to 68d6483 Compare April 29, 2021 15:24

freddyaboulton reviewed Apr 29, 2021

View reviewed changes

Comment thread evalml/preprocessing/data_splitters/time_series_split.py Outdated

ParthivNaresh added 3 commits April 29, 2021 14:45

Remove timeseriessplit reordering and adjust tests for ARIMA exceptio…

73c18a9

…n to DatetimeFeaturizer and DelayedFeatureTransformer

remove sktime manual install

88f7b4b

test coverage change

2580bc3

chukarsten approved these changes Apr 29, 2021

View reviewed changes

ParthivNaresh merged commit 1ed595e into main Apr 29, 2021

ParthivNaresh mentioned this pull request Apr 29, 2021

Build Conda Package Failing due to Networkx Installation #2208

Closed

ParthivNaresh added a commit that referenced this pull request Apr 30, 2021

Revert "User Specified Date Feature (#2155)"

8bc56dd

This reverts commit 1ed595e.

This was referenced Apr 30, 2021

Revert "User Specified Date Feature" #2214

Merged

Build Conda Package Failure during pmdarima installation #2215

Closed

ParthivNaresh added a commit that referenced this pull request Apr 30, 2021

Revert "User Specified Date Feature" (#2214)

6ef200f

* Revert "User Specified Date Feature (#2155)" This reverts commit 1ed595e. * revert release notes

This was referenced May 4, 2021

Initial. #2228

Closed

Release v0.24.0 #2229

Merged

Conversation

ParthivNaresh commented Apr 19, 2021

Uh oh!

codecov Bot commented Apr 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

ParthivNaresh commented Apr 22, 2021

Uh oh!

jeremyliweishih commented Apr 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bchen1116 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bchen1116 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jeremyliweishih left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chukarsten left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

chukarsten Apr 28, 2021

Choose a reason for hiding this comment

Uh oh!

ParthivNaresh Apr 29, 2021

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov Bot commented Apr 20, 2021 •

edited

Loading

jeremyliweishih commented Apr 22, 2021 •

edited

Loading