-
Notifications
You must be signed in to change notification settings - Fork 91
Have OHE return Boolean columns #2170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2170 +/- ##
=========================================
+ Coverage 100.0% 100.0% +0.1%
=========================================
Files 295 295
Lines 24376 24389 +13
=========================================
+ Hits 24366 24379 +13
Misses 10 10
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks great Bryan!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @bchen1116 !!
if name == 'integers': | ||
assert str(types) == "Integer" | ||
else: | ||
assert str(types) == "Boolean" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I love that you made this general and not specific to xgboost.
One check I'd add: assert that the right number of features has been generated. That way, if for some reason the OHE isn't generating any features at all for the bool/category inputs, the test will fail.
fix #2169