Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo data: rename gzip file #2183

Merged
merged 4 commits into from Apr 23, 2021
Merged

Demo data: rename gzip file #2183

merged 4 commits into from Apr 23, 2021

Conversation

dsherry
Copy link
Contributor

@dsherry dsherry commented Apr 22, 2021

I noticed that this tarball wasn't actually a tarball and it was confusing 馃槅

@dsherry dsherry added documentation Improvements or additions to documentation enhancement An improvement to an existing feature. labels Apr 22, 2021
@codecov
Copy link

codecov bot commented Apr 23, 2021

Codecov Report

Merging #2183 (098d5a6) into main (1762f83) will not change coverage.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2183   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files         295      295           
  Lines       24389    24389           
=======================================
  Hits        24379    24379           
  Misses         10       10           
Impacted Files Coverage 螖
evalml/demos/fraud.py 100.0% <100.0%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 1762f83...098d5a6. Read the comment docs.

@dsherry dsherry changed the title Convert from gzipped csv to gzipped tar of csv Rename gzip file Apr 23, 2021
@dsherry dsherry changed the title Rename gzip file Demo data: rename gzip file Apr 23, 2021
@dsherry dsherry marked this pull request as ready for review April 23, 2021 15:08
@@ -8,6 +8,7 @@ Release Notes
* Fixes
* Changes
* Documentation Changes
* Convert demo dataset from gzipped csv to gzipped tar of csv :pr:`2183`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crap, this comment is out of date, updating

Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @dsherry !

Copy link
Contributor

@bchen1116 bchen1116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@dsherry dsherry merged commit 3cde51a into main Apr 23, 2021
@dsherry dsherry deleted the ds_fraud_demo_tarball branch April 23, 2021 16:19
This was referenced May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement An improvement to an existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants