Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the old datasplitters from EvalML #2193

Merged
merged 17 commits into from May 4, 2021
Merged

Remove the old datasplitters from EvalML #2193

merged 17 commits into from May 4, 2021

Conversation

bchen1116
Copy link
Contributor

@bchen1116 bchen1116 commented Apr 26, 2021

Fix #2099

Note: I will likely merge this around the same time I merge 2128, which adds the sampler components to AutoMLSearch. This way, we will still maintain support for imbalanced datasets

@bchen1116 bchen1116 self-assigned this Apr 26, 2021
@codecov
Copy link

codecov bot commented Apr 26, 2021

Codecov Report

Merging #2193 (448d8fa) into main (fcacca2) will decrease coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##             main   #2193     +/-   ##
========================================
- Coverage   100.0%   99.9%   -0.0%     
========================================
  Files         288     280      -8     
  Lines       24610   24152    -458     
========================================
- Hits        24588   24127    -461     
- Misses         22      25      +3     
Impacted Files Coverage Δ
evalml/preprocessing/data_splitters/__init__.py 100.0% <ø> (ø)
evalml/tests/automl_tests/test_automl.py 99.7% <ø> (ø)
evalml/preprocessing/__init__.py 100.0% <100.0%> (ø)
.../automl_tests/test_automl_search_classification.py 100.0% <100.0%> (ø)
evalml/tests/automl_tests/test_automl_utils.py 100.0% <100.0%> (ø)
evalml/automl/automl_search.py 99.0% <0.0%> (-0.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcacca2...448d8fa. Read the comment docs.

@bchen1116 bchen1116 marked this pull request as ready for review April 27, 2021 15:56
Copy link
Contributor

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good from my end. Must have been satisfying to delete all these files

docs/source/release_notes.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@chukarsten chukarsten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RIP

Copy link
Contributor

@angela97lin angela97lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✂️ ✂️ 👍

Copy link
Contributor

@dsherry dsherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@dsherry
Copy link
Contributor

dsherry commented Apr 30, 2021

@bchen1116 oh I think you should also delete evalml/preprocessing/data_splitters/base_splitters.py.

@dsherry
Copy link
Contributor

dsherry commented May 3, 2021

For those following along: the plan is to merge #2128 first, then this PR, and then that unblocks the oversampler work #2213

@bchen1116 bchen1116 merged commit d171296 into main May 4, 2021
This was referenced May 4, 2021
@freddyaboulton freddyaboulton deleted the bc_2099_remove branch May 13, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove old datasplitters
5 participants