New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete baseline pipeline classes #2202
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2202 +/- ##
=========================================
- Coverage 100.0% 100.0% -0.0%
=========================================
Files 296 287 -9
Lines 24712 24451 -261
=========================================
- Hits 24694 24433 -261
Misses 18 18
Continue to review full report at Codecov.
|
"Time Series Baseline Estimator": {"gap": gap, "max_delay": max_delay}}) | ||
return baseline | ||
|
||
def _add_baseline_pipelines(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just separated out helpers to make logic of getting baseline abstracted from training baseline :) No functional change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice changes! LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @angela97lin ! Agree it's a good idea to add tests for the baseline predictions in automl.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closes #2175
Also fixes minor bug with getting input feature names for baseline / pipelines with just one component :)
To discuss: