Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete baseline pipeline classes #2202

Merged
merged 11 commits into from May 2, 2021
Merged

Delete baseline pipeline classes #2202

merged 11 commits into from May 2, 2021

Conversation

angela97lin
Copy link
Contributor

@angela97lin angela97lin commented Apr 28, 2021

Closes #2175

Also fixes minor bug with getting input feature names for baseline / pipelines with just one component :)

To discuss:

  • Still keep tests as automl tests? I decided to add some tests in automl to make sure that we're getting the right predictions.

@angela97lin angela97lin self-assigned this Apr 28, 2021
@codecov
Copy link

codecov bot commented Apr 29, 2021

Codecov Report

Merging #2202 (defdc8f) into main (9d108d7) will decrease coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             main    #2202     +/-   ##
=========================================
- Coverage   100.0%   100.0%   -0.0%     
=========================================
  Files         296      287      -9     
  Lines       24712    24451    -261     
=========================================
- Hits        24694    24433    -261     
  Misses         18       18             
Impacted Files Coverage Δ
evalml/pipelines/__init__.py 100.0% <ø> (ø)
evalml/utils/gen_utils.py 99.6% <ø> (ø)
evalml/automl/automl_search.py 100.0% <100.0%> (ø)
evalml/pipelines/component_graph.py 100.0% <100.0%> (ø)
evalml/tests/automl_tests/test_automl.py 99.7% <100.0%> (+0.1%) ⬆️
.../automl_tests/test_automl_search_classification.py 100.0% <100.0%> (ø)
...ests/automl_tests/test_automl_search_regression.py 100.0% <100.0%> (ø)
...s/prediction_explanations_tests/test_algorithms.py 99.2% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d108d7...defdc8f. Read the comment docs.

"Time Series Baseline Estimator": {"gap": gap, "max_delay": max_delay}})
return baseline

def _add_baseline_pipelines(self):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just separated out helpers to make logic of getting baseline abstracted from training baseline :) No functional change.

@angela97lin angela97lin marked this pull request as ready for review April 29, 2021 18:49
Copy link
Contributor

@bchen1116 bchen1116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changes! LGTM

docs/source/release_notes.rst Show resolved Hide resolved
Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @angela97lin ! Agree it's a good idea to add tests for the baseline predictions in automl.

Copy link
Contributor

@dsherry dsherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 😁

evalml/pipelines/component_graph.py Show resolved Hide resolved
evalml/tests/automl_tests/test_automl.py Show resolved Hide resolved
evalml/tests/automl_tests/test_automl.py Show resolved Hide resolved
@angela97lin angela97lin merged commit 2f7f653 into main May 2, 2021
14 checks passed
@angela97lin angela97lin deleted the 2175_baseline branch May 2, 2021 05:05
This was referenced May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete baseline pipeline classes
4 participants