Delete baseline pipeline classes - #2202
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2202 +/- ##
=========================================
- Coverage 100.0% 100.0% -0.0%
=========================================
Files 296 287 -9
Lines 24712 24451 -261
=========================================
- Hits 24694 24433 -261
Misses 18 18
Continue to review full report at Codecov.
|
angela97lin
commented
Apr 29, 2021
| "Time Series Baseline Estimator": {"gap": gap, "max_delay": max_delay}}) | ||
| return baseline | ||
|
|
||
| def _add_baseline_pipelines(self): |
Contributor
Author
There was a problem hiding this comment.
Just separated out helpers to make logic of getting baseline abstracted from training baseline :) No functional change.
angela97lin
marked this pull request as ready for review
April 29, 2021 18:49
angela97lin
requested review from
ParthivNaresh,
bchen1116,
chukarsten,
dsherry and
freddyaboulton
April 29, 2021 18:49
freddyaboulton
approved these changes
Apr 30, 2021
freddyaboulton
left a comment
Contributor
There was a problem hiding this comment.
Looks great @angela97lin ! Agree it's a good idea to add tests for the baseline predictions in automl.
dsherry
approved these changes
Apr 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2175
Also fixes minor bug with getting input feature names for baseline / pipelines with just one component :)
To discuss: