-
Notifications
You must be signed in to change notification settings - Fork 89
2070 user specified date feature #2217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…n to DatetimeFeaturizer and DelayedFeatureTransformer
Codecov Report
@@ Coverage Diff @@
## main #2217 +/- ##
=========================================
+ Coverage 100.0% 100.0% +0.1%
=========================================
Files 288 288
Lines 24449 24462 +13
=========================================
+ Hits 24431 24444 +13
Misses 18 18
Continue to review full report at Codecov.
|
# Conflicts: # evalml/automl/automl_search.py # evalml/tests/automl_tests/test_automl_search_classification.py # evalml/tests/automl_tests/test_automl_search_regression.py # evalml/tests/pipeline_tests/test_time_series_baseline_pipeline.py
@@ -1,6 +1,8 @@ | |||
name: Build Conda Package | |||
|
|||
on: | |||
pull_request: | |||
types: [ opened, synchronize ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to keep this for feature builds moving forward?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can try it out and if it's too slow we can undo the change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure I am a fan!
@ParthivNaresh I see this in the PR description:
This is no longer true, correct? If so please delete :) |
@dsherry Sorry I meant after this is merged, ARIMA will be updated in another PR :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ParthivNaresh Looks great!
@@ -1,6 +1,8 @@ | |||
name: Build Conda Package | |||
|
|||
on: | |||
pull_request: | |||
types: [ opened, synchronize ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can try it out and if it's too slow we can undo the change?
if not y_none: | ||
y_train, y_test = y.iloc[train], y.iloc[test] | ||
pd.testing.assert_index_equal(y_train.index, answer[i][0]) | ||
pd.testing.assert_index_equal(y_test.index, answer[i][1]) | ||
|
||
|
||
@pytest.mark.parametrize("max_delay,gap,date_index", [(0, 0, "Date"), (1, 0, "Date"), (0, 1, "Date")]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can delete this test? The ts data splitter doesn't sort the data.
@@ -318,7 +318,7 @@ def __init__(self, dummy_int_parameter=0, dummy_categorical_parameter='dummy', d | |||
|
|||
pipeline = BinaryClassificationPipeline([MockEstimator]) | |||
algo = IterativeAlgorithm(allowed_pipelines=[pipeline, pipeline, pipeline], | |||
pipeline_params={'pipeline': {"gap": 2, "max_delay": 10}}, | |||
pipeline_params={'pipeline': {'date_index': "Date", "gap": 2, "max_delay": 10}}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent!!
@@ -2,6 +2,7 @@ Release Notes | |||
------------- | |||
**Future Releases** | |||
* Enhancements | |||
* Added `date_index` as a required parameter for TimeSeries problems :pr:`2217` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Fixes #2070
This is a refiling of the old PR with the previous (main) version of ARIMA. After this is merged, ARIMA will be updated in a different PR using
sktime
as opposed tostatsmodels
.