Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating demo datasets to retain column names #223

Merged
merged 3 commits into from Nov 19, 2019
Merged

Updating demo datasets to retain column names #223

merged 3 commits into from Nov 19, 2019

Conversation

angela97lin
Copy link
Contributor

@angela97lin angela97lin commented Nov 18, 2019

Closes #214

@codecov
Copy link

codecov bot commented Nov 18, 2019

Codecov Report

Merging #223 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #223      +/-   ##
==========================================
+ Coverage   96.56%   96.57%   +<.01%     
==========================================
  Files          92       92              
  Lines        2416     2422       +6     
==========================================
+ Hits         2333     2339       +6     
  Misses         83       83
Impacted Files Coverage Δ
evalml/demos/diabetes.py 100% <100%> (ø) ⬆️
evalml/demos/wine.py 100% <100%> (ø) ⬆️
evalml/demos/breast_cancer.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1169b40...6f11306. Read the comment docs.

@angela97lin angela97lin self-assigned this Nov 19, 2019
kmax12
kmax12 approved these changes Nov 19, 2019
Copy link
Contributor

@kmax12 kmax12 left a comment

LGTM. We should update these methods further to include the proper target names after @dsherry finishes #215

@angela97lin
Copy link
Contributor Author

angela97lin commented Nov 19, 2019

All right; made a separate issue (#224) to follow up on this, merging and closing this for now :)

@angela97lin angela97lin merged commit 1b3eb40 into master Nov 19, 2019
@angela97lin angela97lin mentioned this pull request Dec 16, 2019
@angela97lin angela97lin deleted the qs branch Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve quick start dataset
3 participants