Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set max_depth to 1 in dfs calls #2231

Merged
merged 2 commits into from May 6, 2021
Merged

Conversation

freddyaboulton
Copy link
Contributor

Pull Request Description

Fixes #2219


After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of docs/source/release_notes.rst to include this pull request by adding :pr:123.

@codecov
Copy link

codecov bot commented May 5, 2021

Codecov Report

Merging #2231 (05c434e) into main (3fc568d) will increase coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2231     +/-   ##
=======================================
+ Coverage   99.9%   99.9%   +0.1%     
=======================================
  Files        280     280             
  Lines      24089   24105     +16     
=======================================
+ Hits       24064   24080     +16     
  Misses        25      25             
Impacted Files Coverage Δ
...ponents/transformers/preprocessing/featuretools.py 100.0% <ø> (ø)
...ents/transformers/preprocessing/text_featurizer.py 100.0% <ø> (ø)
evalml/tests/component_tests/test_featuretools.py 100.0% <100.0%> (ø)
...alml/tests/component_tests/test_text_featurizer.py 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fc568d...05c434e. Read the comment docs.

Copy link
Contributor

@angela97lin angela97lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clean, LGTM 👍

Copy link
Contributor

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!

Copy link
Contributor

@bchen1116 bchen1116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Contributor

@dsherry dsherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

When we do the next release, let's make sure we run text datasets and see if this decreased the runtime.

Copy link
Contributor

@ParthivNaresh ParthivNaresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@freddyaboulton freddyaboulton merged commit 587750c into main May 6, 2021
@freddyaboulton freddyaboulton deleted the 2219-set-max-depth-1-dfs branch May 6, 2021 20:04
@chukarsten chukarsten mentioned this pull request May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use max_depth=1 in code that uses featuretools to avoid warning
6 participants