Set max_depth to 1 in dfs calls#2231
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2231 +/- ##
=======================================
+ Coverage 99.9% 99.9% +0.1%
=======================================
Files 280 280
Lines 24089 24105 +16
=======================================
+ Hits 24064 24080 +16
Misses 25 25
Continue to review full report at Codecov.
|
freddyaboulton
force-pushed
the
2219-set-max-depth-1-dfs
branch
from
3d53f87 to
8f5e2fe
Compare
freddyaboulton
requested review from
ParthivNaresh,
angela97lin,
bchen1116,
chukarsten,
dsherry and
jeremyliweishih
and removed request for
angela97lin and
dsherry
angela97lin
approved these changes
May 5, 2021
angela97lin
left a comment
angela97lin
left a comment
Contributor
There was a problem hiding this comment.
Nice and clean, LGTM 👍
freddyaboulton
force-pushed
the
2219-set-max-depth-1-dfs
branch
from
8f5e2fe to
05c434e
Compare
dsherry
approved these changes
May 6, 2021
dsherry
left a comment
dsherry
left a comment
Contributor
There was a problem hiding this comment.
LGTM!
When we do the next release, let's make sure we run text datasets and see if this decreased the runtime.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fixes #2219
After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of
docs/source/release_notes.rstto include this pull request by adding :pr:123.