Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use codecov action to upload coverage reports #2238

Merged
merged 9 commits into from
May 19, 2021
Merged

Use codecov action to upload coverage reports #2238

merged 9 commits into from
May 19, 2021

Conversation

rwedge
Copy link
Contributor

@rwedge rwedge commented May 6, 2021

Fixes #2232 by switching to codecov's github action

@CLAassistant
Copy link

CLAassistant commented May 6, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@dsherry dsherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @rwedge 🙏

Approved if CI passes and the codecov report looks correct!

I just updated the branch to rekick CI

@dsherry dsherry added refactor Work being done to refactor code. testing Issues related to testing. labels May 14, 2021
@chukarsten
Copy link
Contributor

I pushed to the branch the release notes note to get it to pass CI!

@rwedge
Copy link
Contributor Author

rwedge commented May 18, 2021

As a sanity check, we'll want codecov bot to comment on the PR with the coverage report

So far files haven't been uploaded successfully
Screen Shot 2021-05-18 at 10 30 33 AM

@codecov
Copy link

codecov bot commented May 18, 2021

Codecov Report

Merging #2238 (1ee0743) into main (c47a6a1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2238   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files         280      280           
  Lines       24392    24392           
=======================================
  Hits        24370    24370           
  Misses         22       22           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c47a6a1...1ee0743. Read the comment docs.

@rwedge rwedge merged commit 0c10cd5 into main May 19, 2021
@rwedge rwedge deleted the rw-issue-2232 branch May 19, 2021 13:20
@chukarsten chukarsten mentioned this pull request May 24, 2021
@chukarsten chukarsten mentioned this pull request Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Work being done to refactor code. testing Issues related to testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update codecov upload step in linux unit tests
4 participants