New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove excess data splitter calls #2253
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2253 +/- ##
=========================================
+ Coverage 89.6% 100.0% +10.4%
=========================================
Files 280 280
Lines 24330 24322 -8
=========================================
+ Hits 21780 24300 +2520
+ Misses 2550 22 -2528
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did codecov not catch this, if we don't have anything that calls transform_sample
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bchen1116 !
Noticed that my previous PR removing the sampling data splitter didn't remove some extra lines that called the data splitter.
Since we are now defaulting to StratifiedKFold and no longer have data splitters with a
transform_sample
method, I removed the excess code