Remove excess data splitter calls#2253
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2253 +/- ##
=========================================
+ Coverage 89.6% 100.0% +10.4%
=========================================
Files 280 280
Lines 24330 24322 -8
=========================================
+ Hits 21780 24300 +2520
+ Misses 2550 22 -2528
Continue to review full report at Codecov.
|
angela97lin
reviewed
May 11, 2021
Contributor
angela97lin
left a comment
There was a problem hiding this comment.
Did codecov not catch this, if we don't have anything that calls transform_sample?
freddyaboulton
approved these changes
May 11, 2021
Contributor
freddyaboulton
left a comment
There was a problem hiding this comment.
Thanks @bchen1116 !
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed that my previous PR removing the sampling data splitter didn't remove some extra lines that called the data splitter.
Since we are now defaulting to StratifiedKFold and no longer have data splitters with a
transform_samplemethod, I removed the excess code