Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove excess data splitter calls #2253

Merged
merged 7 commits into from May 13, 2021
Merged

Remove excess data splitter calls #2253

merged 7 commits into from May 13, 2021

Conversation

bchen1116
Copy link
Contributor

@bchen1116 bchen1116 commented May 11, 2021

Noticed that my previous PR removing the sampling data splitter didn't remove some extra lines that called the data splitter.

Since we are now defaulting to StratifiedKFold and no longer have data splitters with a transform_sample method, I removed the excess code

@bchen1116 bchen1116 self-assigned this May 11, 2021
@codecov
Copy link

codecov bot commented May 11, 2021

Codecov Report

Merging #2253 (71d3916) into main (6499428) will increase coverage by 10.4%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            main    #2253      +/-   ##
=========================================
+ Coverage   89.6%   100.0%   +10.4%     
=========================================
  Files        280      280              
  Lines      24330    24322       -8     
=========================================
+ Hits       21780    24300    +2520     
+ Misses      2550       22    -2528     
Impacted Files Coverage Δ
evalml/automl/automl_search.py 100.0% <ø> (+1.4%) ⬆️
evalml/pipelines/utils.py 100.0% <0.0%> (+1.0%) ⬆️
evalml/tests/conftest.py 100.0% <0.0%> (+1.1%) ⬆️
...derstanding/prediction_explanations/_algorithms.py 98.9% <0.0%> (+1.2%) ⬆️
evalml/tests/component_tests/test_estimators.py 100.0% <0.0%> (+1.9%) ⬆️
evalml/tests/component_tests/test_components.py 100.0% <0.0%> (+2.8%) ⬆️
evalml/tests/utils_tests/test_dependencies.py 88.9% <0.0%> (+3.8%) ⬆️
evalml/tests/component_tests/test_utils.py 97.5% <0.0%> (+3.8%) ⬆️
...valml/tests/pipeline_tests/test_component_graph.py 100.0% <0.0%> (+3.9%) ⬆️
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6499428...71d3916. Read the comment docs.

Copy link
Contributor

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

Copy link
Contributor

@angela97lin angela97lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did codecov not catch this, if we don't have anything that calls transform_sample?

Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bchen1116 !

@bchen1116 bchen1116 merged commit 40a8765 into main May 13, 2021
@chukarsten chukarsten mentioned this pull request May 17, 2021
@freddyaboulton freddyaboulton deleted the bc_remove_sampler_calls branch May 13, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants