Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing on Windows CircleCI #226

Merged
merged 17 commits into from Nov 20, 2019
Merged

Testing on Windows CircleCI #226

merged 17 commits into from Nov 20, 2019

Conversation

christopherbunn
Copy link
Contributor

@christopherbunn christopherbunn commented Nov 19, 2019

Resolves #142

@codecov
Copy link

codecov bot commented Nov 19, 2019

Codecov Report

Merging #226 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #226   +/-   ##
=======================================
  Coverage   96.57%   96.57%           
=======================================
  Files          92       92           
  Lines        2422     2422           
=======================================
  Hits         2339     2339           
  Misses         83       83

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b3eb40...bd1651d. Read the comment docs.

@christopherbunn
Copy link
Contributor Author

christopherbunn commented Nov 19, 2019

Running the unit tests on Windows requires three additional containers that run slightly longer than the linux containers. Do we want the Windows containers to run with every commit across all branches or should they only run on the master branch?

@jeremyliweishih
Copy link
Contributor

jeremyliweishih commented Nov 19, 2019

I feel like running it on every commit would be overkill.

Copy link
Contributor

@jeremyliweishih jeremyliweishih left a comment

LGTM other than maybe running it only for master? @kmax12

jeremyliweishih
jeremyliweishih previously approved these changes Nov 20, 2019
- run:
name: Download Miniconda
command: |
$File = ".\Miniconda3-4.7.12.1-Windows-x86_64.exe"
Copy link
Contributor

@rwedge rwedge Nov 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we create a config variable so when we update the miniconda version we only need to change the name once?

Copy link
Contributor Author

@christopherbunn christopherbunn Nov 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to have file name (with version) as well as the file hash as a parameter.

rwedge
rwedge approved these changes Nov 20, 2019
Copy link
Contributor

@rwedge rwedge left a comment

Looks good!

@christopherbunn christopherbunn merged commit daef8e9 into master Nov 20, 2019
@angela97lin angela97lin mentioned this pull request Dec 16, 2019
@dsherry dsherry deleted the win-circleci branch May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run CircleCi unit tests on Windows
3 participants