Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing on Windows CircleCI #226

Merged
merged 17 commits into from
Nov 20, 2019
Merged

Testing on Windows CircleCI #226

merged 17 commits into from
Nov 20, 2019

Conversation

christopherbunn
Copy link
Contributor

@christopherbunn christopherbunn commented Nov 19, 2019 •
edited
Loading

Resolves #142

@codecov
Copy link

codecov bot commented Nov 19, 2019 •
edited
Loading

Codecov Report

Merging #226 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #226   +/-   ##
=======================================
  Coverage   96.57%   96.57%           
=======================================
  Files          92       92           
  Lines        2422     2422           
=======================================
  Hits         2339     2339           
  Misses         83       83

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b3eb40...bd1651d. Read the comment docs.

@christopherbunn
Copy link
Contributor Author

Running the unit tests on Windows requires three additional containers that run slightly longer than the linux containers. Do we want the Windows containers to run with every commit across all branches or should they only run on the master branch?

@jeremyliweishih
Copy link
Collaborator

I feel like running it on every commit would be overkill.

jeremyliweishih
jeremyliweishih requested changes Nov 19, 2019
View reviewed changes
Copy link
Collaborator

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than maybe running it only for master? @kmax12

rwedge
rwedge reviewed Nov 20, 2019
View reviewed changes
.circleci/config.yml Outdated
- run:
name: Download Miniconda
command: |
$File = ".\Miniconda3-4.7.12.1-Windows-x86_64.exe"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we create a config variable so when we update the miniconda version we only need to change the name once?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to have file name (with version) as well as the file hash as a parameter.

rwedge
rwedge approved these changes Nov 20, 2019
View reviewed changes
Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@christopherbunn christopherbunn merged commit daef8e9 into master Nov 20, 2019
@angela97lin angela97lin mentioned this pull request Dec 16, 2019
Merged
@dsherry dsherry deleted the win-circleci branch May 26, 2020 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwedge rwedge rwedge approved these changes

@jeremyliweishih jeremyliweishih jeremyliweishih left review comments

@kmax12 kmax12 Awaiting requested review from kmax12

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run CircleCi unit tests on Windows
3 participants
@christopherbunn @jeremyliweishih @rwedge