Docs build: refactor markupsafe dependency pin to be outside of requirements.txt #2261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherry
added
documentation
dsherry
force-pushed
the
ds_rtd_markupsafe_pin
branch
from
ccc5ec5
to
a5f046d
Compare
dsherry
changed the title
Codecov Report
@@ Coverage Diff @@
## main #2261 +/- ##
=========================================
+ Coverage 89.5% 100.0% +10.5%
=========================================
Files 280 280
Lines 24392 24392
=========================================
+ Hits 21827 24369 +2542
+ Misses 2565 23 -2542
Continue to review full report at Codecov.
|
dsherry
commented
May 18, 2021
| - method: pip | ||
| path: . | ||
| - requirements: docs-requirements.txt |
There was a problem hiding this comment.
This is what did it. First install evalml dependencies, then install the pinned MarkupSafe 1.1.1 (which was already done in docs/docs-requirements.txt before this PR)
There was a problem hiding this comment.
It should be ok to remove the MarkupSafe requirement from docs-requirements as well, since nbsphinx>=0.8.5, which is present in the docs requirements, also addresses the Markupsafe issue in its own requirements
dsherry
commented
May 18, 2021
| @@ -5,7 +5,6 @@ ipywidgets>=7.5 | |||
| xgboost>=0.82,<1.3.0 | |||
| catboost>=0.20 | |||
| lightgbm>=2.3.1,<3.1.0 | |||
| MarkupSafe==1.1.1 | |||
dsherry
force-pushed
the
ds_rtd_markupsafe_pin
branch
from
8fa17ca
to
739f41a
Compare
rwedge
approved these changes
May 18, 2021
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up from #2244 .
Since
MarkupSafeis only needed for the docs, and is not needed to run evalml, it shouldn't be listed in ourrequirements.txt. So this PR moves it out of there.Thanks to @rwedge for the ultimate solution!