Update AutoMLSearch init Pipeline logging - #2263
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2263 +/- ##
=========================================
+ Coverage 100.0% 100.0% +0.1%
=========================================
Files 280 280
Lines 24318 24336 +18
=========================================
+ Hits 24296 24314 +18
Misses 22 22
Continue to review full report at Codecov.
|
ParthivNaresh
marked this pull request as ready for review
May 13, 2021 20:09
ParthivNaresh
requested review from
angela97lin,
bchen1116,
chukarsten,
dsherry,
freddyaboulton and
jeremyliweishih
and removed request for
dsherry and
freddyaboulton
May 13, 2021 20:09
dsherry
approved these changes
May 14, 2021
dsherry
left a comment
dsherry
left a comment
Contributor
There was a problem hiding this comment.
Cool! Left two nit picks
bchen1116
approved these changes
May 14, 2021
bchen1116
left a comment
bchen1116
left a comment
Contributor
There was a problem hiding this comment.
LGTM! I think it'd be nice to add some simple test coverage, left a comment on suggestions but not necessary to implement all! I think just one test to check the output would be good
….com/alteryx/evalml into Update-Logging-Information-AutoML-Init
….com/alteryx/evalml into Update-Logging-Information-AutoML-Init
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2092