Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AutoMLSearch init Pipeline logging #2263

Merged
merged 20 commits into from May 18, 2021

Conversation

ParthivNaresh
Copy link
Contributor

@ParthivNaresh ParthivNaresh commented May 13, 2021

Fixes #2092

@codecov
Copy link

codecov bot commented May 13, 2021

Codecov Report

Merging #2263 (ad5b49e) into main (2f7246d) will increase coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             main    #2263     +/-   ##
=========================================
+ Coverage   100.0%   100.0%   +0.1%     
=========================================
  Files         280      280             
  Lines       24318    24336     +18     
=========================================
+ Hits        24296    24314     +18     
  Misses         22       22             
Impacted Files Coverage Δ
evalml/automl/automl_search.py 100.0% <100.0%> (ø)
evalml/tests/utils_tests/test_logger.py 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f7246d...ad5b49e. Read the comment docs.

@ParthivNaresh ParthivNaresh marked this pull request as ready for review May 13, 2021 20:09
Copy link
Contributor

@dsherry dsherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Left two nit picks

evalml/automl/automl_search.py Outdated Show resolved Hide resolved
evalml/automl/automl_search.py Outdated Show resolved Hide resolved
Copy link
Contributor

@bchen1116 bchen1116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think it'd be nice to add some simple test coverage, left a comment on suggestions but not necessary to implement all! I think just one test to check the output would be good

evalml/automl/automl_search.py Show resolved Hide resolved
Copy link
Contributor

@chukarsten chukarsten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ParthivNaresh ParthivNaresh merged commit 077ec74 into main May 18, 2021
@freddyaboulton freddyaboulton deleted the Update-Logging-Information-AutoML-Init branch May 13, 2022 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update logged information for AutoML init
4 participants