Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change number of cores for pytest from 4 to 2 #2266

Merged
merged 9 commits into from
May 14, 2021
Merged

Change number of cores for pytest from 4 to 2 #2266

merged 9 commits into from
May 14, 2021

Conversation

gsheni
Copy link
Contributor

@gsheni gsheni commented May 13, 2021

  • Change number of cores for pytest from 4 to 2

@gsheni gsheni self-assigned this May 13, 2021
@gsheni gsheni changed the title Update Makefile Change number of cores for pytest from 4 to 2 May 13, 2021
@codecov
Copy link

codecov bot commented May 13, 2021

Codecov Report

Merging #2266 (9adc9a5) into main (d6c6b5d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2266   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files         280      280           
  Lines       24369    24369           
=======================================
  Hits        24347    24347           
  Misses         22       22           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6c6b5d...9adc9a5. Read the comment docs.

Copy link
Contributor

@dsherry dsherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. Did this because GH actions workers have 2 cores, whereas our old circleci builders had more. Looking at the unit test CI in this PR, I don't see a significant change in runtime vs current main, which is as expected.

https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources

This reminds me that I think we're at the point where we're gonna need to have multiple unit test jobs which run in parallel!

@gsheni gsheni marked this pull request as ready for review May 14, 2021 20:55
@gsheni gsheni merged commit 9c1e2e1 into main May 14, 2021
@gsheni gsheni deleted the reduce_n_pytest branch May 14, 2021 21:53
@chukarsten chukarsten mentioned this pull request May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants