Add minimum dependency generator GitHub Action #2267
Conversation
| if [[ $(expr match "${{ github.event.pull_request.head.ref }}" "release_v[0-9.]\+") -gt 0 ]]; then | ||
| exit 0; | ||
| elif [[ $(expr match "${{ github.event.pull_request.head.ref }}" "dep-update-[a-zA-Z0-9]*") -gt 0 ]]; then | ||
| elif [[ $(expr match "${{ github.event.pull_request.head.ref }}" "latest-dep-update-[a-zA-Z0-9]*") -gt 0 ]]; then |
There was a problem hiding this comment.
Updated the release notes check to skip latest and minimum dependency branches
There was a problem hiding this comment.
Good call
There's probably a fancy unix way to do this in one if check hahaha but I don't know what it is right away at least
gsheni
requested review from
ParthivNaresh,
angela97lin,
dsherry and
freddyaboulton
Codecov Report
@@ Coverage Diff @@
## main #2267 +/- ##
=======================================
Coverage 100.0% 100.0%
=======================================
Files 280 280
Lines 24357 24357
=======================================
Hits 24335 24335
Misses 22 22 Continue to review full report at Codecov.
|
freddyaboulton
left a comment
freddyaboulton
left a comment
There was a problem hiding this comment.
@gsheni I think this looks good!
| uses: alteryx/minimum-dependency-generator@v2 | ||
| with: | ||
| requirements_paths: 'core-requirements.txt' | ||
| - name: Save min core requirements and run diff |
There was a problem hiding this comment.
There's a way in GH actions to define a "function" which could accept an arg like the requirements file name, and then execute the diff and file write, and then we could call that "function" 3x instead of copy-pasting the code, right? Not required for this PR lol just curious
Uh oh!
There was an error while loading. Please reload this page.