Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minimum dependency generator GitHub Action #2267

Merged
merged 11 commits into from May 14, 2021
Merged

Conversation

gsheni
Copy link
Contributor

@gsheni gsheni commented May 13, 2021

@gsheni gsheni self-assigned this May 13, 2021
@@ -28,7 +30,9 @@ jobs:
run: |
if [[ $(expr match "${{ github.event.pull_request.head.ref }}" "release_v[0-9.]\+") -gt 0 ]]; then
exit 0;
elif [[ $(expr match "${{ github.event.pull_request.head.ref }}" "dep-update-[a-zA-Z0-9]*") -gt 0 ]]; then
elif [[ $(expr match "${{ github.event.pull_request.head.ref }}" "latest-dep-update-[a-zA-Z0-9]*") -gt 0 ]]; then
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the release notes check to skip latest and minimum dependency branches

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call
There's probably a fancy unix way to do this in one if check hahaha but I don't know what it is right away at least

@gsheni gsheni marked this pull request as ready for review May 13, 2021 16:34
@codecov
Copy link

codecov bot commented May 13, 2021

Codecov Report

Merging #2267 (9d712c8) into main (3a7ee46) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2267   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files         280      280           
  Lines       24357    24357           
=======================================
  Hits        24335    24335           
  Misses         22       22           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a7ee46...9d712c8. Read the comment docs.

Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gsheni I think this looks good!

uses: alteryx/minimum-dependency-generator@v2
with:
requirements_paths: 'core-requirements.txt'
- name: Save min core requirements and run diff
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a way in GH actions to define a "function" which could accept an arg like the requirements file name, and then execute the diff and file write, and then we could call that "function" 3x instead of copy-pasting the code, right? Not required for this PR lol just curious

Copy link
Contributor

@dsherry dsherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gsheni thank you for adding this! I love it.

@gsheni gsheni merged commit dc56896 into main May 14, 2021
@gsheni gsheni deleted the add_min_dep_checker branch May 14, 2021 16:27
@chukarsten chukarsten mentioned this pull request May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants