Add unit tests with minimum dependencies#2277
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2277 +/- ##
=======================================
Coverage 100.0% 100.0%
=======================================
Files 280 280
Lines 24396 24396
=======================================
Hits 24373 24373
Misses 23 23 Continue to review full report at Codecov.
|
gsheni
requested review from
ParthivNaresh,
angela97lin,
chukarsten,
dsherry and
freddyaboulton
ParthivNaresh
left a comment
ParthivNaresh
left a comment
There was a problem hiding this comment.
Looks good to me, nice catch on upgrading numpy to fix the shap issue!
| featuretools==0.20.0 | ||
| featuretools==0.21.0 | ||
| dask==2.12.0 | ||
| distributed==2.12.0 |
There was a problem hiding this comment.
How come we need to add this package? Should be pulled in by featuretools no?
There was a problem hiding this comment.
The reason I had to add this is the following pip warning/error (which I saw after installing minimum_test_requirements.txt):
distributed 2021.5.0 has requirement dask==2021.05.0, but you'll have dask 2.12.0 which is incompatible.
There was a problem hiding this comment.
actually disregard that, I think the unit tests still pass on Linux without putting distributed.
Yes, ideally it should be pulled by featuretools (but my local Mac wasn't doing it).
freddyaboulton
left a comment
freddyaboulton
left a comment
There was a problem hiding this comment.
@gsheni This looks great! Thanks for splitting up the tests into core and non-core too. I have a couple of questions about why we had to add/bump dependencies before I approve.
| pytest==4.4.1 | ||
| pytest-xdist==1.26.1 | ||
| pytest-cov==2.6.1 | ||
| wheel>=0.33.1 |
There was a problem hiding this comment.
How come we need to add wheel and setuptools and bump pytest dependencies?
There was a problem hiding this comment.
I needed to add wheel and setuptools to make sure that numpy properly installed.
In addition, if you don't have wheel installed it takes longer to install some packages from PyPI (it does python setup.py install for each requirement). So installing wheel first fixes this.
There was a problem hiding this comment.
I bumped pytest because the old pytest had lower requirements that conflicted with requirements I was bumping.
freddyaboulton
left a comment
freddyaboulton
left a comment
There was a problem hiding this comment.
Thank you @gsheni !!
4 participants
Uh oh!
There was an error while loading. Please reload this page.