-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding PipelinePlot class #228
Conversation
Codecov Report
@@ Coverage Diff @@
## master #228 +/- ##
=========================================
+ Coverage 97.3% 97.3% +<.01%
=========================================
Files 94 95 +1
Lines 2706 2712 +6
=========================================
+ Hits 2633 2639 +6
Misses 73 73
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. We just need to get it into the API reference
@kmax12 yup, trying to get it to work for ROC / Auto(*) right now and will update this too when I figure it out :D |
ya, it might be a bit tricky... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Updating on #173, moving visualization to PipelinePlot class.