Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding PipelinePlot class #228

Merged
merged 25 commits into from Dec 5, 2019
Merged

Adding PipelinePlot class #228

merged 25 commits into from Dec 5, 2019

Conversation

angela97lin
Copy link
Contributor

@angela97lin angela97lin commented Nov 19, 2019

Updating on #173, moving visualization to PipelinePlot class.

@codecov
Copy link

codecov bot commented Nov 19, 2019

Codecov Report

Merging #228 into master will increase coverage by <.01%.
The diff coverage is 91.11%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #228      +/-   ##
=========================================
+ Coverage    97.3%   97.3%   +<.01%     
=========================================
  Files          94      95       +1     
  Lines        2706    2712       +6     
=========================================
+ Hits         2633    2639       +6     
  Misses         73      73
Impacted Files Coverage Δ
evalml/pipelines/pipeline_base.py 97.33% <100%> (+1.75%) ⬆️
...valml/tests/pipeline_tests/test_pipelines_plots.py 100% <100%> (ø)
evalml/pipelines/pipeline_plots.py 89.18% <89.18%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b10c1fe...0f0abaf. Read the comment docs.

@angela97lin angela97lin requested a review from kmax12 Nov 19, 2019
kmax12
kmax12 previously approved these changes Nov 19, 2019
Copy link
Contributor

@kmax12 kmax12 left a comment

Looks good. We just need to get it into the API reference

@angela97lin
Copy link
Contributor Author

angela97lin commented Nov 19, 2019

@kmax12 yup, trying to get it to work for ROC / Auto(*) right now and will update this too when I figure it out :D

@kmax12
Copy link
Contributor

kmax12 commented Nov 19, 2019

@kmax12 yup, trying to get it to work for ROC / Auto(*) right now and will update this too when I figure it out :D

ya, it might be a bit tricky...

@angela97lin angela97lin self-assigned this Dec 2, 2019
kmax12
kmax12 approved these changes Dec 2, 2019
Copy link
Contributor

@kmax12 kmax12 left a comment

LGTM

docs/source/changelog.rst Show resolved Hide resolved
@angela97lin angela97lin requested a review from kmax12 Dec 5, 2019
kmax12
kmax12 approved these changes Dec 5, 2019
Copy link
Contributor

@kmax12 kmax12 left a comment

LGTM

@angela97lin angela97lin merged commit 36d3a0e into master Dec 5, 2019
@angela97lin angela97lin deleted the vis branch Dec 5, 2019
@angela97lin angela97lin mentioned this pull request Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants