Move default_parameters to ComponentGraph from PipelineBase#2307
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2307 +/- ##
=====================================
Coverage 99.9% 99.9%
=====================================
Files 281 281
Lines 24608 24607 -1
=====================================
- Hits 24579 24578 -1
Misses 29 29
Continue to review full report at Codecov.
|
freddyaboulton
left a comment
There was a problem hiding this comment.
@angela97lin Looks good! I have a question about the release notes though.
|
|
||
| **Breaking Changes** | ||
| * Updated ``start_iteration_callback`` to accept a pipeline instance instead of a pipeline class and no longer accept pipeline parameters as a parameter :pr:`2290` | ||
| * Moved ``default_parameters`` to ``ComponentGraph`` from ``PipelineBase``. A pipeline's ``default_parameters`` is now accessible via ``pipeline.component_graph.default_parameters`` :pr:`2307` |
There was a problem hiding this comment.
I think users would need to do pipeline._component_graph. How come users need to access a private attribute to get the default parameters now? I think I missed the context for this change 🙈 Is there a plan to make pipeline.component_graph be a reference to the ComponentGraph as opposed to list/dict representation?
There was a problem hiding this comment.
Yup, you're right!
Filed #2331, gonna work on it in a separate branch c:
(I believe its because we relied on the input component graph aka component_graph to determine if linear but also wanted to store _component_graph aka the underlying graph structure.)
Closes #2167