Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move default_parameters to ComponentGraph from PipelineBase #2307

Merged
merged 11 commits into from Jun 3, 2021

Conversation

angela97lin
Copy link
Contributor

Closes #2167

@angela97lin angela97lin self-assigned this May 26, 2021
@codecov
Copy link

codecov bot commented May 26, 2021

Codecov Report

Merging #2307 (de77ea8) into main (f01a4d0) will not change coverage.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2307   +/-   ##
=====================================
  Coverage   99.9%   99.9%           
=====================================
  Files        281     281           
  Lines      24608   24607    -1     
=====================================
- Hits       24579   24578    -1     
  Misses        29      29           
Impacted Files Coverage Δ
evalml/pipelines/pipeline_base.py 99.7% <ø> (-<0.1%) ⬇️
evalml/pipelines/component_graph.py 100.0% <100.0%> (ø)
...lml/tests/automl_tests/test_iterative_algorithm.py 100.0% <100.0%> (ø)
evalml/tests/pipeline_tests/test_pipelines.py 99.9% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f01a4d0...de77ea8. Read the comment docs.

Copy link
Contributor

@bchen1116 bchen1116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@angela97lin Looks good! I have a question about the release notes though.

@@ -33,6 +34,7 @@ Release Notes

**Breaking Changes**
* Updated ``start_iteration_callback`` to accept a pipeline instance instead of a pipeline class and no longer accept pipeline parameters as a parameter :pr:`2290`
* Moved ``default_parameters`` to ``ComponentGraph`` from ``PipelineBase``. A pipeline's ``default_parameters`` is now accessible via ``pipeline.component_graph.default_parameters`` :pr:`2307`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think users would need to do pipeline._component_graph. How come users need to access a private attribute to get the default parameters now? I think I missed the context for this change 🙈 Is there a plan to make pipeline.component_graph be a reference to the ComponentGraph as opposed to list/dict representation?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, you're right!

Filed #2331, gonna work on it in a separate branch c:
(I believe its because we relied on the input component graph aka component_graph to determine if linear but also wanted to store _component_graph aka the underlying graph structure.)

evalml/pipelines/component_graph.py Outdated Show resolved Hide resolved
@angela97lin angela97lin merged commit 8c6c362 into main Jun 3, 2021
@angela97lin angela97lin deleted the 2167_default_params branch June 3, 2021 03:04
@chukarsten chukarsten mentioned this pull request Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move "default_parameters" accessor from PipelineBase to ComponentGraph
4 participants