Fix build_conda_pkg - #2323
Merged
Merged
Fix build_conda_pkg#2323
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2323 +/- ##
=======================================
- Coverage 99.9% 99.9% -0.0%
=======================================
Files 280 280
Lines 24490 24492 +2
=======================================
+ Hits 24463 24464 +1
- Misses 27 28 +1
Continue to review full report at Codecov.
|
freddyaboulton
commented
Jun 1, 2021
| def test_saving_png_file(tmpdir, test_pipeline): | ||
| def test_saving_png_file(tmpdir, test_pipeline, is_using_conda): | ||
| if is_using_conda: | ||
| pytest.skip("Skipping saving_png_file if running during conda build process.") |
Contributor
Author
There was a problem hiding this comment.
This line will only be run during the build_conda_pkg job. Since it's just pytest.skip I think it's ok to merge.
freddyaboulton
marked this pull request as ready for review
June 1, 2021 20:34
freddyaboulton
requested review from
ParthivNaresh,
angela97lin,
bchen1116,
chukarsten,
dsherry and
jeremyliweishih
June 1, 2021 20:35
jeremyliweishih
approved these changes
Jun 1, 2021
jeremyliweishih
left a comment
jeremyliweishih
left a comment
Collaborator
There was a problem hiding this comment.
looks good! need a higher power (@dsherry) to either merge this in first or the latest dependency PR though.
angela97lin
approved these changes
Jun 1, 2021
angela97lin
left a comment
angela97lin
left a comment
Contributor
There was a problem hiding this comment.
🙏
Is there a issue up to track removing this once we figure out the root cause?
chukarsten
approved these changes
Jun 1, 2021
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Disable broken test on gh-action build_conda_pkg job.
After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of
docs/source/release_notes.rstto include this pull request by adding :pr:123.