Conversation
Codecov Report
@@ Coverage Diff @@
## main #2350 +/- ##
=====================================
Coverage 99.7% 99.7%
=====================================
Files 283 283
Lines 25233 25233
=====================================
Hits 25133 25133
Misses 100 100
Continue to review full report at Codecov.
|
angela97lin
left a comment
There was a problem hiding this comment.
Just to make sure I understand the purpose of this: this is supposed to check that the packages evalml depends on are up to date? From the README, it sounded like it would automatically download the latest version of evalml but I tried to purposely downgrade evalml (to 0.24.0) an run python -m pip install evalml[update_checker] and nothing happened?
|
@angela97 this will only work once it is merged into main and released. In addition, it will only work with versions of EvalML going forward. The way this would work is the following.
|
angela97lin
left a comment
There was a problem hiding this comment.
@gsheni Got it, thank you for explaining! I wonder if there's a clearer way to express this in the README, but otherwise this looks good! Thanks @jeff-hernandez for doing this 😁
|
@jeff-hernandez One thing I just realized, we should add this to the Install page |
dsherry
left a comment
There was a problem hiding this comment.
@jeff-hernandez looks great! One blocking change: please move the python code to evalml/utils/
I also left a comment for @freddyaboulton and @chukarsten to dig into--they've been working on our CI recently. But that's not blocking merge
dsherry
left a comment
There was a problem hiding this comment.
Thanks @jeff-hernandez looks great! Left two docs nit-picks but not blocking merge
README.md
Outdated
| **Update checker** <br> | ||
| Receive automatic notifications of new EvalML releases | ||
| ``` | ||
| python -m pip install evalml[update_checker] |
There was a problem hiding this comment.
Mega nit-pick but elsewhere in our docs we say pip install ... instead of python -m pip install ...
docs/source/install.ipynb
Outdated
| "**Update checker** <br>\n", | ||
| "Receive automatic notifications of new EvalML releases\n", | ||
| "```\n", | ||
| "python -m pip install evalml[update_checker]\n", |
Addressed comments
Addressed comments
Closes #2333 by adding the Alteryx open-source update checker. The update checker will automatically check if there's a newer release of EvalML available.