Fix ComponentGraph appending target to final_component_features if there is a component that returns both X and y - #2358
Merged
Merged
Conversation
angela97lin
changed the title
Codecov Report
@@ Coverage Diff @@
## main #2358 +/- ##
=======================================
+ Coverage 99.7% 99.7% +0.1%
=======================================
Files 281 281
Lines 24925 24934 +9
=======================================
+ Hits 24828 24837 +9
Misses 97 97
Continue to review full report at Codecov.
|
angela97lin
commented
Jun 10, 2021
|
|
||
| parent_inputs = [ | ||
| parent_input | ||
| for parent_input in self.get_parents(self.compute_order[-1]) |
Contributor
Author
There was a problem hiding this comment.
We default to component name --> pass X so just checking that we're not checking a .y parent input :)
angela97lin
requested review from
ParthivNaresh,
bchen1116,
chukarsten,
dsherry,
freddyaboulton and
jeremyliweishih
June 10, 2021 19:41
angela97lin
marked this pull request as ready for review
June 10, 2021 19:41
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2280