Fix partial dependence graph method failing on multiclass problems when the label is numeric#2372
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2372 +/- ##
========================================
+ Coverage 89.3% 99.7% +10.4%
========================================
Files 281 281
Lines 24907 24926 +19
========================================
+ Hits 22222 24829 +2607
+ Misses 2685 97 -2588
Continue to review full report at Codecov.
|
| assert len(two_way_part_dep.columns) == grid_resolution + 1 | ||
|
|
||
|
|
||
| def test_partial_dependence_multiclass_numeric_labels( |
There was a problem hiding this comment.
@freddyaboulton I'm sure you might have some opinions about me adding yet another long running test 😂 I wasn't confident in a way to mock things but definitely would love suggestions/opinions!
There was a problem hiding this comment.
What's the runtime now? My takeaway is that using grid_resolution=5 can trim the test time to a couple seconds down from like ~10. The next step would be using fewer rows.
There was a problem hiding this comment.
~30-40 seconds before, 8 seconds after setting grid_resolution to 5 😁
chukarsten
left a comment
There was a problem hiding this comment.
Looks good. I think dropping the grid res is a good idea to make it a shorter test.
freddyaboulton
left a comment
There was a problem hiding this comment.
Looks good to me @angela97lin !
Closes #2114