Fix k_neighbors issue with SMOTE oversamplers #2375
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2375 +/- ##
=======================================
+ Coverage 99.7% 99.7% +0.1%
=======================================
Files 281 281
Lines 24934 24963 +29
=======================================
+ Hits 24837 24866 +29
Misses 97 97
Continue to review full report at Codecov.
|
| n_jobs=-1, | ||
| random_seed=0, | ||
| **kwargs | ||
| **kwargs, |
There was a problem hiding this comment.
this got added by black
…c_2324_kneighbors
bchen1116
requested review from
ParthivNaresh,
angela97lin,
chukarsten,
dsherry,
freddyaboulton and
jeremyliweishih
and removed request for
chukarsten
chukarsten
left a comment
chukarsten
left a comment
There was a problem hiding this comment.
Love it - it's quick, intuitive solution with a good test. Is there anyway we can communicate what's happening to the user? I'm still not sure how we're using warnings or logging, but I'd prefer, philosophically, for us to let the user know everytime we change the behavior they expect under the covers.
| f"Minority class needs more than 1 sample to use SMOTE!, received {min_counts} sample" | ||
| ) | ||
| if min_counts <= neighbors: | ||
| neighbors = min_counts - 1 |
There was a problem hiding this comment.
I like the solution. I just would prefer if the user knew what was happening. Do we have a way that we can communicate to the user, who thinks that k_neighbors_default is one value that it's being reduced due to their input?
There was a problem hiding this comment.
I could introduce a k_neighbors parameter that becomes the value we set it to in the parameters dictionary? This way, users can see the parameter when they look at the param dic, but I don't think our other components currently log any changes they make internally. We don't raise any changes here and here.
Does this sound fine to you @chukarsten?
angela97lin
left a comment
angela97lin
left a comment
There was a problem hiding this comment.
LGTM! left some nitpicking :]
evalml/pipelines/components/transformers/samplers/base_sampler.py
Outdated
Show resolved
Hide resolved
| k: v | ||
| for k, v in copy.copy(self.parameters).items() | ||
| if k not in ["sampling_ratio", "sampling_ratio_dict"] | ||
| for k, v in self.parameters.items() |
There was a problem hiding this comment.
Do you know why we copied before and why its okay that we remove this?
There was a problem hiding this comment.
This was something Karsten pointed out, but since we're making a copied dictionary from the parameters, I don't think it's necessary for us to copy the dictionary.
There was a problem hiding this comment.
We do a lot of copying throughout the code base....I feel like it might be someone (rightfully) scared of overwriting the originals.
fix #2324
Design doc here