Separate dask job #2376
Separate dask job #2376
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2376 +/- ##
=======================================
- Coverage 99.9% 99.7% -0.2%
=======================================
Files 281 281
Lines 24907 24907
=======================================
- Hits 24874 24810 -64
- Misses 33 97 +64
Continue to review full report at Codecov.
|
Makefile
Outdated
|
|
||
| .PHONY: test-dask | ||
| test: | ||
| pytest evalml/tests/automl_tests/dask_tests/ --doctest-modules --doctest-continue-on-failure |
There was a problem hiding this comment.
Can you add the --timeout 360 ?
chukarsten
force-pushed
the
separate_dask_job
branch
from
04f41aa
to
d67e6a3
Compare
…ll the other test options.
… with the number of workers explicitly set to one.
chukarsten
force-pushed
the
separate_dask_job
branch
from
578fd77
to
d52f70f
Compare
| @@ -19,23 +19,35 @@ lint-fix: | |||
|
|
|||
| .PHONY: test | |||
| test: | |||
| pytest evalml/ --doctest-modules --doctest-continue-on-failure | |||
| pytest evalml/ --doctest-modules --doctest-continue-on-failure --ignore=evalml/tests/automl_tests/dask_tests | |||
There was a problem hiding this comment.
I'd rather we still had one command to run all tests but this is not blocking merge.
There was a problem hiding this comment.
I'll do a quick PR to reintroduce this. Good point
| - main | ||
|
|
||
| jobs: | ||
| win_unit_tests: |
There was a problem hiding this comment.
I'll file an issue for trying to reduce as many of the set-up steps as possible between the dask-only and non-dask tests. I think that'll pay off in the future.
No description provided.