Skip to content

Separate dask job#2376

Merged
chukarsten merged 15 commits into
mainfrom
separate_dask_job
Jun 14, 2021
Merged

Separate dask job#2376
chukarsten merged 15 commits into
mainfrom
separate_dask_job

Conversation

@chukarsten

Copy link
Copy Markdown
Contributor

No description provided.

@codecov

codecov Bot commented Jun 11, 2021

Copy link
Copy Markdown

Codecov Report

Merging #2376 (d52f70f) into main (ca42b84) will decrease coverage by 0.3%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2376     +/-   ##
=======================================
- Coverage   99.9%   99.7%   -0.2%     
=======================================
  Files        281     281             
  Lines      24907   24907             
=======================================
- Hits       24874   24810     -64     
- Misses        33      97     +64     
Impacted Files Coverage Δ
.../tests/automl_tests/dask_tests/test_automl_dask.py 100.0% <ø> (ø)
.../tests/automl_tests/dask_tests/test_dask_engine.py 100.0% <ø> (ø)
evalml/automl/engine/dask_engine.py 34.1% <0.0%> (-65.9%) ⬇️
evalml/tests/automl_tests/dask_test_utils.py 66.7% <0.0%> (-32.0%) ⬇️
evalml/automl/engine/engine_base.py 98.5% <0.0%> (-1.5%) ⬇️
evalml/automl/automl_search.py 99.4% <0.0%> (-0.5%) ⬇️
evalml/tests/conftest.py 99.6% <0.0%> (-0.4%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca42b84...d52f70f. Read the comment docs.

Comment thread Makefile Outdated

.PHONY: test-dask
test:
pytest evalml/tests/automl_tests/dask_tests/ --doctest-modules --doctest-continue-on-failure

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the --timeout 360 ?

@freddyaboulton freddyaboulton left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chukarsten !

Comment thread Makefile
.PHONY: test
test:
pytest evalml/ --doctest-modules --doctest-continue-on-failure
pytest evalml/ --doctest-modules --doctest-continue-on-failure --ignore=evalml/tests/automl_tests/dask_tests

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather we still had one command to run all tests but this is not blocking merge.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do a quick PR to reintroduce this. Good point

- main

jobs:
win_unit_tests:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll file an issue for trying to reduce as many of the set-up steps as possible between the dask-only and non-dask tests. I think that'll pay off in the future.

@chukarsten chukarsten merged commit a096a7c into main Jun 14, 2021
@chukarsten chukarsten deleted the separate_dask_job branch June 14, 2021 22:33
@chukarsten chukarsten mentioned this pull request Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants