Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpinning PyZMQ #2389

Merged
merged 2 commits into from Jun 18, 2021
Merged

Unpinning PyZMQ #2389

merged 2 commits into from Jun 18, 2021

Conversation

christopherbunn
Copy link
Contributor

Testing to see if the Windows issues are resolved...
Resolves #1759

@codecov
Copy link

codecov bot commented Jun 16, 2021

Codecov Report

Merging #2389 (119a748) into main (9da6a71) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2389   +/-   ##
=====================================
  Coverage   99.7%   99.7%           
=====================================
  Files        281     281           
  Lines      25057   25057           
=====================================
  Hits       24957   24957           
  Misses       100     100           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9da6a71...119a748. Read the comment docs.

@christopherbunn
Copy link
Contributor Author

Looks like the Windows unit tests are passing, will update the release notes

@@ -3,7 +3,6 @@ pandas>=1.2.1
scipy>=1.3.3
scikit-learn>=0.24.0
scikit-optimize>=0.8.1
pyzmq>=20.0.0,<22.0.0
Copy link
Contributor

@gsheni gsheni Jun 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would also suggest removing it from here (though min dep checker will handle it if you don't in an automated PR after you merge into main).

Copy link
Contributor

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christopherbunn christopherbunn merged commit d9fd7b1 into main Jun 18, 2021
@christopherbunn christopherbunn deleted the 1759_unpin_pyzmq branch June 21, 2021 14:53
@chukarsten chukarsten mentioned this pull request Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unpin pyzmq
3 participants