Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Miscellaneous CI updates #2395

Merged
merged 4 commits into from Jun 17, 2021
Merged

Miscellaneous CI updates #2395

merged 4 commits into from Jun 17, 2021

Conversation

dsherry
Copy link
Contributor

@dsherry dsherry commented Jun 17, 2021 •
edited

Follow-on to #2365 which was just merged.

Changes

  • Rename tests so they're a little easier to read in the list which appears at the bottom of each PR
  • Run lint on python 3.9
  • Run nightlies on python 3.8 too (why not?)
  • Have the nightlies run at 3am EST instead of 7am, just in case anyone is working early 馃槅

dsherry
dsherry commented Jun 17, 2021
View reviewed changes
.github/workflows/build_conda_pkg.yml
@@ -1,4 +1,4 @@
name: Build Conda Package
name: Build conda package
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Call me out if there's no point updating this lol, I just figured it'd be easier to read in the list

dsherry
dsherry commented Jun 17, 2021
View reviewed changes
.github/workflows/linux_unit_tests_with_latest_deps.yml
@@ -1,4 +1,4 @@
name: Linux Unit Tests with Latest Dependencies
name: Unit tests, linux, latest dependencies
Copy link
Contributor Author

@dsherry dsherry Jun 17, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Listing the job type first and platform second makes it easier to visually distinguish between the jobs.

@codecov
Copy link

codecov bot commented Jun 17, 2021 •
edited

Codecov Report

Merging #2395 (30455d7) into main (d79bcae) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2395   +/-   ##
=====================================
  Coverage   99.7%   99.7%           
=====================================
  Files        281     281           
  Lines      25014   25014           
=====================================
  Hits       24917   24917           
  Misses        97      97

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update d79bcae...30455d7. Read the comment docs.

@dsherry dsherry changed the title Cosmetic updates to CI Miscellaneous CI updates Jun 17, 2021
@dsherry dsherry marked this pull request as ready for review June 17, 2021 21:39
@dsherry dsherry added the testing Issues related to testing. label Jun 17, 2021
freddyaboulton
freddyaboulton approved these changes Jun 17, 2021
View reviewed changes
Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dsherry Looks good to me! I don't have a preference for when the nightlies are run but right now I think it's set to 11 pm because of UTC.

.github/workflows/linux_nightlies.yml

on:
schedule:
- cron: '0 7 * * *'
- cron: '0 3 * * *'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI the cron is in UTC so this is actually 11 pm EST. I think before it was set to 3 am EST.

https://docs.github.com/en/actions/reference/events-that-trigger-workflows#scheduled-events

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh 馃挬 I'm sorry! I'll change it back

.github/workflows/linux_nightlies.yml
@@ -11,7 +11,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python_version: ['3.7', '3.9']
python_version: ['3.7', '3.8', '3.9']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me! 馃憤

jeremyliweishih
jeremyliweishih approved these changes Jun 17, 2021
View reviewed changes
Copy link
Contributor

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I think these changes make it more clear!

@dsherry dsherry merged commit 6816361 into main Jun 17, 2021
@dsherry dsherry mentioned this pull request Jun 17, 2021
Merged
@chukarsten chukarsten mentioned this pull request Jun 22, 2021
Merged
@freddyaboulton freddyaboulton deleted the ds_pr_ci_update branch May 13, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremyliweishih jeremyliweishih jeremyliweishih approved these changes

@freddyaboulton freddyaboulton freddyaboulton approved these changes

@chukarsten chukarsten Awaiting requested review from chukarsten

Assignees

@dsherry dsherry

Labels
testing Issues related to testing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dsherry @jeremyliweishih @freddyaboulton