Miscellaneous CI updates - #2395
Conversation
| @@ -1,4 +1,4 @@ | |||
| name: Build Conda Package | |||
| name: Build conda package | |||
There was a problem hiding this comment.
Call me out if there's no point updating this lol, I just figured it'd be easier to read in the list
| @@ -1,4 +1,4 @@ | |||
| name: Linux Unit Tests with Latest Dependencies | |||
| name: Unit tests, linux, latest dependencies | |||
There was a problem hiding this comment.
Listing the job type first and platform second makes it easier to visually distinguish between the jobs.
Codecov Report
@@ Coverage Diff @@
## main #2395 +/- ##
=====================================
Coverage 99.7% 99.7%
=====================================
Files 281 281
Lines 25014 25014
=====================================
Hits 24917 24917
Misses 97 97 Continue to review full report at Codecov.
|
freddyaboulton
left a comment
freddyaboulton
left a comment
There was a problem hiding this comment.
@dsherry Looks good to me! I don't have a preference for when the nightlies are run but right now I think it's set to 11 pm because of UTC.
| on: | ||
| schedule: | ||
| - cron: '0 7 * * *' | ||
| - cron: '0 3 * * *' |
There was a problem hiding this comment.
FYI the cron is in UTC so this is actually 11 pm EST. I think before it was set to 3 am EST.
https://docs.github.com/en/actions/reference/events-that-trigger-workflows#scheduled-events
There was a problem hiding this comment.
Oh 💩 I'm sorry! I'll change it back
| fail-fast: false | ||
| matrix: | ||
| python_version: ['3.7', '3.9'] | ||
| python_version: ['3.7', '3.8', '3.9'] |
There was a problem hiding this comment.
Sounds good to me! 👍
jeremyliweishih
left a comment
jeremyliweishih
left a comment
There was a problem hiding this comment.
LGTM - I think these changes make it more clear!
3 participants
Follow-on to #2365 which was just merged.
Changes