Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Logistic Regression match other files #2399

Merged
merged 5 commits into from Jun 18, 2021
Merged

Make Logistic Regression match other files #2399

merged 5 commits into from Jun 18, 2021

Conversation

bchen1116
Copy link
Contributor

fix #1649

@bchen1116 bchen1116 self-assigned this Jun 17, 2021
@codecov
Copy link

codecov bot commented Jun 17, 2021

Codecov Report

Merging #2399 (0245931) into main (8ab66ec) will not change coverage.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2399   +/-   ##
=====================================
  Coverage   99.7%   99.7%           
=====================================
  Files        281     281           
  Lines      25014   25014           
=====================================
  Hits       24917   24917           
  Misses        97      97           
Impacted Files Coverage Δ
evalml/tests/component_tests/test_components.py 100.0% <ø> (ø)
...ines/components/estimators/classifiers/__init__.py 100.0% <100.0%> (ø)
...tors/classifiers/logistic_regression_classifier.py 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ab66ec...0245931. Read the comment docs.

Copy link
Contributor

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bchen1116 bchen1116 marked this pull request as ready for review June 18, 2021 14:43
Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bchen1116 !

@bchen1116 bchen1116 merged commit 8c51031 into main Jun 18, 2021
@chukarsten chukarsten mentioned this pull request Jun 22, 2021
@freddyaboulton freddyaboulton deleted the bc_1649_logistic branch May 13, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logistic Regression Updates
3 participants