Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set fail fast to false for PR jobs #2402

Merged
merged 3 commits into from Jun 18, 2021
Merged

Conversation

freddyaboulton
Copy link
Contributor

Pull Request Description

Set fail fast to false for pr jobs given our discussion.


After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of docs/source/release_notes.rst to include this pull request by adding :pr:123.

@codecov
Copy link

codecov bot commented Jun 18, 2021

Codecov Report

Merging #2402 (78e1297) into main (dc836d8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2402   +/-   ##
=====================================
  Coverage   99.7%   99.7%           
=====================================
  Files        281     281           
  Lines      25057   25057           
=====================================
  Hits       24957   24957           
  Misses       100     100           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc836d8...78e1297. Read the comment docs.

Copy link
Contributor

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great thanks!

@freddyaboulton freddyaboulton merged commit 9da6a71 into main Jun 18, 2021
@freddyaboulton freddyaboulton deleted the set-fail-fast-false-in-ci branch June 18, 2021 20:15
@chukarsten chukarsten mentioned this pull request Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants