Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncappling LightGBM #2405

Merged
merged 3 commits into from
Jun 21, 2021
Merged

Uncappling LightGBM #2405

merged 3 commits into from
Jun 21, 2021

Conversation

christopherbunn
Copy link
Contributor

Will need to check doc output before merging.

Resolves #1713

@codecov
Copy link

codecov bot commented Jun 18, 2021

Codecov Report

Merging #2405 (c14f20e) into main (81730da) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2405   +/-   ##
=====================================
  Coverage   99.7%   99.7%           
=====================================
  Files        283     283           
  Lines      25233   25233           
=====================================
  Hits       25133   25133           
  Misses       100     100           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81730da...c14f20e. Read the comment docs.

@christopherbunn christopherbunn marked this pull request as ready for review June 21, 2021 14:52
Copy link
Contributor

@dsherry dsherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚢 😁

@@ -12,6 +12,7 @@ Release Notes
* Replaced `allowed_pipelines` with `allowed_component_graphs` :pr:`2364`
* Removed private method ``_compute_features_during_fit`` from ``PipelineBase`` :pr:`2359`
* Unpinned PyZMQ version in requirements.txt :pr:`2389`
* Uncapping LightGBM version in requirements.txt :pr:`2405`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a mega nit-pick which you can ignore for this PR: we have tried to phrase our release notes entries in past-tense. "Uncapped LightGBM version"

Copy link
Contributor

@bchen1116 bchen1116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@christopherbunn christopherbunn merged commit 9e85e34 into main Jun 21, 2021
@christopherbunn christopherbunn deleted the 1713_uncap_lightgbm branch June 21, 2021 15:45
@chukarsten chukarsten mentioned this pull request Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uncap LightGBM Version
3 participants