-
Notifications
You must be signed in to change notification settings - Fork 91
Uncappling LightGBM #2405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uncappling LightGBM #2405
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2405 +/- ##
=====================================
Coverage 99.7% 99.7%
=====================================
Files 283 283
Lines 25233 25233
=====================================
Hits 25133 25133
Misses 100 100 Continue to review full report at Codecov.
|
b484fb6 to
b57ef8a
Compare
dsherry
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚢 😁
| * Replaced `allowed_pipelines` with `allowed_component_graphs` :pr:`2364` | ||
| * Removed private method ``_compute_features_during_fit`` from ``PipelineBase`` :pr:`2359` | ||
| * Unpinned PyZMQ version in requirements.txt :pr:`2389` | ||
| * Uncapping LightGBM version in requirements.txt :pr:`2405` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a mega nit-pick which you can ignore for this PR: we have tried to phrase our release notes entries in past-tense. "Uncapped LightGBM version"
bchen1116
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Will need to check doc output before merging.
Resolves #1713