Skip to content

Update compute_order in ComponentGraph to be a read-only property #2408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jun 22, 2021
Merged

Update compute_order in ComponentGraph to be a read-only property #2408

merged 11 commits into from
Jun 22, 2021

Conversation

@angela97lin
Copy link
Contributor

@angela97lin angela97lin commented Jun 20, 2021

Closes #2342

@codecov
Copy link

codecov bot commented Jun 20, 2021 •
edited
Loading

Codecov Report

Merging #2408 (ffabf9c) into main (7487189) will increase coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2408     +/-   ##
=======================================
+ Coverage   99.7%   99.7%   +0.1%     
=======================================
  Files        283     283             
  Lines      25244   25247      +3     
=======================================
+ Hits       25144   25147      +3     
  Misses       100     100
Impacted Files Coverage Δ
evalml/pipelines/component_graph.py 99.4% <100.0%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7487189...ffabf9c. Read the comment docs.

chukarsten
chukarsten approved these changes Jun 21, 2021
View reviewed changes
Copy link
Contributor

@chukarsten chukarsten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@angela97lin angela97lin merged commit 369c2e0 into main Jun 22, 2021
@angela97lin angela97lin deleted the 2342_compute_order branch June 22, 2021 20:06
@chukarsten chukarsten mentioned this pull request Jun 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@chukarsten chukarsten chukarsten approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@angela97lin angela97lin

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update compute_order in ComponentGraph to be a read-only property

3 participants

@angela97lin @chukarsten