Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ROC and confusion matrix #242

Merged
merged 108 commits into from Dec 4, 2019
Merged

Add ROC and confusion matrix #242

merged 108 commits into from Dec 4, 2019

Conversation

angela97lin
Copy link
Contributor

@angela97lin angela97lin commented Nov 25, 2019

Closes #195

(Branched off ROC branch because of plotly fixes and setup)

@angela97lin angela97lin self-assigned this Dec 2, 2019
@angela97lin angela97lin changed the title WIP: add confusion matrix Add ROC and confusion matrix Dec 2, 2019
@angela97lin angela97lin requested a review from kmax12 Dec 2, 2019
@angela97lin
Copy link
Contributor Author

angela97lin commented Dec 2, 2019

Note of discussion: if user passes in own additional objectives, should ROC / confusion matrix be calculated regardless?

Edit: added issue #246 to address this in the future.

evalml/objectives/standard_metrics.py Outdated Show resolved Hide resolved
evalml/objectives/standard_metrics.py Outdated Show resolved Hide resolved
docs/source/conf.py Outdated Show resolved Hide resolved
docs/source/conf.py Outdated Show resolved Hide resolved
evalml/models/__init__.py Outdated Show resolved Hide resolved
evalml/models/auto_classifier.py Outdated Show resolved Hide resolved
evalml/models/auto_regressor.py Outdated Show resolved Hide resolved
evalml/objectives/objective_base.py Outdated Show resolved Hide resolved
Copy link
Contributor

@kmax12 kmax12 left a comment

couple last comments. almost there

evalml/models/__init__.py Outdated Show resolved Hide resolved

"""
if self.data.problem_type != ProblemTypes.BINARY:
raise RuntimeError("ROC plots can only be generated for binary classification problems.")
Copy link
Contributor

@kmax12 kmax12 Dec 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the plotting methods that call a get_data method, i dont think we need to duplicate these checks since they will get check anyways in the get data

evalml/models/pipeline_search_plots.py Show resolved Hide resolved
evalml/models/pipeline_search_plots.py Show resolved Hide resolved
@angela97lin angela97lin requested a review from kmax12 Dec 3, 2019
kmax12
kmax12 approved these changes Dec 4, 2019
Copy link
Contributor

@kmax12 kmax12 left a comment

LGTM

@angela97lin angela97lin merged commit b10c1fe into master Dec 4, 2019
@angela97lin angela97lin mentioned this pull request Dec 16, 2019
@angela97lin angela97lin deleted the confusion branch Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to calculate and plot confusion matrix
2 participants