-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ROC and confusion matrix #242
Conversation
Note of discussion: if user passes in own additional objectives, should ROC / confusion matrix be calculated regardless? Edit: added issue #246 to address this in the future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple last comments. almost there
|
||
""" | ||
if self.data.problem_type != ProblemTypes.BINARY: | ||
raise RuntimeError("ROC plots can only be generated for binary classification problems.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for the plotting methods that call a get_data
method, i dont think we need to duplicate these checks since they will get check anyways in the get data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #195
(Branched off ROC branch because of plotly fixes and setup)