Repository navigation
Using LRC with elasticnet penalty - #2420
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2420 +/- ##
=======================================
- Coverage 99.7% 99.7% -0.0%
=======================================
Files 283 283
Lines 25321 25316 -5
=======================================
- Hits 25221 25216 -5
Misses 100 100
Continue to review full report at Codecov.
|
bchen1116
marked this pull request as ready for review
June 22, 2021 22:00
bchen1116
requested review from
ParthivNaresh,
angela97lin,
christopherbunn,
chukarsten,
dsherry,
freddyaboulton and
jeremyliweishih
June 22, 2021 22:00
jeremyliweishih
approved these changes
Jun 22, 2021
jeremyliweishih
left a comment
Collaborator
There was a problem hiding this comment.
LGTM @bchen1116 awesome work! The only thing we could add to the unit tests is coverage to ensure NaNs don't show up again but we might be covered from the notebook.
freddyaboulton
approved these changes
Jun 22, 2021
freddyaboulton
left a comment
Contributor
There was a problem hiding this comment.
Perf tests look good to me!
chukarsten
approved these changes
Jun 22, 2021
chukarsten
left a comment
Contributor
There was a problem hiding this comment.
Per the n_jobs = 1 or -1, I think we're gucci. Great job getting this done.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #2289 #2281
Replacement of 2381
Rather than using SGDClassifier for ElasticNet, we now use Logistic Regression with ElasticNet penalty.
Perfs here
Doc assertion passes for lead scoring!


Optimized with lead scoring:
Optimized with AUC: