Skip to content

Using LRC with elasticnet penalty - #2420

Merged
bchen1116 merged 9 commits into
mainfrom
bc_lr_test
Jun 22, 2021
Merged

bchen1116 merged 9 commits into
mainfrom
bc_lr_test

Conversation

@bchen1116

@bchen1116 bchen1116 commented Jun 22, 2021 •

Copy link
Copy Markdown
Contributor

fix #2289 #2281
Replacement of 2381

Rather than using SGDClassifier for ElasticNet, we now use Logistic Regression with ElasticNet penalty.
Perfs here

Doc assertion passes for lead scoring!
Optimized with lead scoring:
image
Optimized with AUC:
image

@bchen1116 bchen1116 self-assigned this Jun 22, 2021
@codecov

codecov Bot commented Jun 22, 2021 •

Copy link
Copy Markdown

Codecov Report

Merging #2420 (cb2c94b) into main (96abe4a) will decrease coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2420     +/-   ##
=======================================
- Coverage   99.7%   99.7%   -0.0%     
=======================================
  Files        283     283             
  Lines      25321   25316      -5     
=======================================
- Hits       25221   25216      -5     
  Misses       100     100             
Impacted Files Coverage Δ
evalml/tests/automl_tests/test_automl.py 99.8% <ø> (-<0.1%) ⬇️
evalml/tests/component_tests/test_components.py 100.0% <ø> (ø)
...valml/tests/pipeline_tests/test_component_graph.py 100.0% <ø> (ø)
evalml/tests/pipeline_tests/test_pipeline_utils.py 100.0% <ø> (ø)
evalml/tests/pipeline_tests/test_pipelines.py 99.8% <ø> (ø)
...ts/estimators/classifiers/elasticnet_classifier.py 100.0% <100.0%> (ø)
evalml/tests/component_tests/test_en_classifier.py 100.0% <100.0%> (ø)
...s/prediction_explanations_tests/test_algorithms.py 98.3% <100.0%> (-<0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96abe4a...cb2c94b. Read the comment docs.

@jeremyliweishih jeremyliweishih left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @bchen1116 awesome work! The only thing we could add to the unit tests is coverage to ensure NaNs don't show up again but we might be covered from the notebook.

@freddyaboulton freddyaboulton left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perf tests look good to me!

@chukarsten chukarsten left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per the n_jobs = 1 or -1, I think we're gucci. Great job getting this done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Perf test and deep dive into Elastic Net

4 participants