Pandas 1.3.0 Upgrade#2442
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2442 +/- ##
=======================================
+ Coverage 99.7% 99.7% +0.1%
=======================================
Files 283 283
Lines 25568 25571 +3
=======================================
+ Hits 25466 25469 +3
Misses 102 102
Continue to review full report at Codecov.
|
chukarsten
force-pushed
the
pandas_1.3.0_check
branch
from
105d752 to
3065481
Compare
…ad of the RangeIndex object it was after the update.
…rom cropping up again.
chukarsten
force-pushed
the
pandas_1.3.0_check
branch
from
3065481 to
9864b19
Compare
chukarsten
commented
Jul 8, 2021
chukarsten
commented
Jul 8, 2021
chukarsten
commented
Jul 8, 2021
Contributor
Author
chukarsten
left a comment
chukarsten
left a comment
There was a problem hiding this comment.
The two places that the pandas upgrade from 1.2.5 to 1.3.0 manifested themselves were:
- The columns of XGBoost's DMatrix created from the new DataFrame resulted in the integer column labels being prepended extra spaces so that they would be strings with exactly two characters. Not sure why this happens with the new Pandas, but I think this is a pandas/XGBoost interaction, so might file an issue there.
- The order, but not the values, of some of the datacheck validation results has changed. The affected tests are rewritten so the order doesn't matter.
chukarsten
requested review from
ParthivNaresh,
angela97lin,
bchen1116,
christopherbunn,
dsherry,
freddyaboulton and
jeremyliweishih
freddyaboulton
approved these changes
Jul 8, 2021
Contributor
freddyaboulton
left a comment
freddyaboulton
left a comment
There was a problem hiding this comment.
Looks good to me @chukarsten ! Thanks for doing this.
angela97lin
approved these changes
Jul 8, 2021
Contributor
angela97lin
left a comment
angela97lin
left a comment
There was a problem hiding this comment.
Not that you needed another green seal of approval, but LGTM!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses issues introduced with Pandas 1.3.0 rc1. #2431 Preliminary work required to prepare for Woodwork 0.5.0.