Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run build_conda_pkg only on changes to requirements files #2446

Merged
merged 5 commits into from
Jun 28, 2021

Conversation

freddyaboulton
Copy link
Contributor

@freddyaboulton freddyaboulton commented Jun 25, 2021

Pull Request Description

Fixes #2416

We're "speeding up" the job by running it only when a dependency version is added/updated or when latest/min dependencies are updated.


After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of docs/source/release_notes.rst to include this pull request by adding :pr:123.

@codecov
Copy link

codecov bot commented Jun 25, 2021

Codecov Report

Merging #2446 (762a4ad) into main (020e434) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2446   +/-   ##
=====================================
  Coverage   99.7%   99.7%           
=====================================
  Files        283     283           
  Lines      25500   25500           
=====================================
  Hits       25400   25400           
  Misses       100     100           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 020e434...762a4ad. Read the comment docs.

@freddyaboulton freddyaboulton marked this pull request as ready for review June 25, 2021 20:03
Copy link
Contributor

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! the build conda pkg check is hanging because it won't run but is required right? Will need an intervention to change that 😄

@freddyaboulton
Copy link
Contributor Author

@jeremyliweishih Yes! I'm hoping @dsherry can help on Monday!

Copy link
Contributor

@bchen1116 bchen1116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Contributor

@dsherry dsherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@freddyaboulton ok, seems cool to me!

We may end up wanting to keep this enabled on merges to main just to have continuous proof things are alright. I am fine with removing it for now though.

I removed this job from our branch protections, so you are clear to merge.

@freddyaboulton
Copy link
Contributor Author

@dsherry Modified the yaml so that it will run on merges to main!

@freddyaboulton freddyaboulton merged commit c2f1b6d into main Jun 28, 2021
@freddyaboulton freddyaboulton deleted the 2416-speed-up-build_conda_pkg branch June 28, 2021 14:46
@dsherry dsherry mentioned this pull request Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Speed up build_conda_pkg
4 participants