Pinned WW top at 0.4.2 and bottom at 0.4.1 #2460
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2460 +/- ##
=====================================
Coverage 99.7% 99.7%
=====================================
Files 283 283
Lines 25500 25500
=====================================
Hits 25400 25400
Misses 100 100 Continue to review full report at Codecov.
|
dsherry
reviewed
Jun 30, 2021
core-requirements.txt
Outdated
| shap>=0.36.0 | ||
| texttable>=1.6.2 | ||
| woodwork>=0.4.1 | ||
| woodwork>=0.4.1,<=0.4.2 |
Contributor
There was a problem hiding this comment.
Should we do woodwork>=0.4.1,<0.5.0? If they follow semantic versioning, 0.5.0 will be the next breaking change
Contributor
There was a problem hiding this comment.
Agreed, <0.5.0 is the right approach, and will avoid the upcoming breaking change.
freddyaboulton
approved these changes
Jun 30, 2021
Contributor
There was a problem hiding this comment.
@chukarsten Looks good to me once we set the upper version at < 5.0.0! Thank you!
Updated upper limit
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for woodwork 0.5.0 release and evaluate the new type in #2459 .