Repository navigation
Quick fix to retain typing - #2461
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2461 +/- ##
=======================================
+ Coverage 99.7% 99.7% +0.1%
=======================================
Files 283 283
Lines 25709 25730 +21
=======================================
+ Hits 25608 25629 +21
Misses 101 101
Continue to review full report at Codecov.
|
|
@chukarsten did you mean to say "Fixes #2456 " in the description above? |
7b91064 to
7d3cfc7
Compare
3dfbbb3 to
16eb6ff
Compare
| @@ -110,13 +111,20 @@ def _retain_custom_types_and_initalize_woodwork( | |||
| return ww.init_series(new_dataframe, old_logical_types) | |||
| if ltypes_to_ignore is None: | |||
There was a problem hiding this comment.
@freddyaboulton do we have a plan for phasing out _retain_custom_types_and_initialize_woodwork? I know your PR dropped some usages of it. If we need to file an issue with WW to move some functionality over, I'll do it.
There was a problem hiding this comment.
@chukarsten I think we need it for the time being for the Imputer because the imputer will "break" the schema and we need a way of recreating it while allowing some of the types to change. I've been told that alteryx/woodwork#965 will help with that but I think we need to think about that further.
angela97lin
left a comment
angela97lin
left a comment
There was a problem hiding this comment.
LGTM, thanks for doing this! Do we have an issue tracking removing this code once WW makes their changes? 😮
b138003 to
c885d78
Compare
freddyaboulton
left a comment
freddyaboulton
left a comment
There was a problem hiding this comment.
Looks good to me @chukarsten !
bchen1116
left a comment
bchen1116
left a comment
There was a problem hiding this comment.
Looks good! Left a question, but nothing blocking. Would be nice to file an issue to track removing this once WW fixes!
Addressed comments about user defined order and dt format checking.
5 participants
Addresses: #2456
This modifies the for-loop to handle Ordinal and Datetime ltypes to pass through the properties that were missing. The other ltypes are still handled the same way. When Woodwork addresses this, we can revert this change.