Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete unreachable line in IterativeAlgorithm #2464

Merged
merged 2 commits into from
Jul 1, 2021

Conversation

freddyaboulton
Copy link
Contributor

@freddyaboulton freddyaboulton commented Jul 1, 2021

Pull Request Description

Fixes #2338

The uncovered line originally mentioned in #2338 is now covered but there's still an uncovered line!

We previously check that all custom_hyperparameters are instances of skopt spaces:

for hyperparam_name_val in self._custom_hyperparameters.values():
    for _, hyperparam_val in hyperparam_name_val.items():
        if not isinstance(hyperparam_val, (Integer, Real, Categorical)):
            raise ValueError(
                "Custom hyperparameters should only contain skopt.Space variables such as Categorical, Integer,"
                " and Real!"
            )

So the else clause I'm deleting can't be changed.


After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of docs/source/release_notes.rst to include this pull request by adding :pr:123.

@codecov
Copy link

codecov bot commented Jul 1, 2021

Codecov Report

Merging #2464 (8b4a5bf) into main (cee8518) will increase coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2464     +/-   ##
=======================================
+ Coverage   99.6%   99.6%   +0.1%     
=======================================
  Files        283     283             
  Lines      25488   25486      -2     
=======================================
- Hits       25385   25384      -1     
+ Misses       103     102      -1     
Impacted Files Coverage Δ
...lml/automl/automl_algorithm/iterative_algorithm.py 100.0% <ø> (+0.9%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cee8518...8b4a5bf. Read the comment docs.

Copy link
Contributor

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool makes sense!

Copy link
Contributor

@angela97lin angela97lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@freddyaboulton freddyaboulton merged commit ef06526 into main Jul 1, 2021
@freddyaboulton freddyaboulton deleted the 2338-delete-line-iterative-algorithm branch July 1, 2021 16:12
@dsherry dsherry mentioned this pull request Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete or add code coverage for line in IterativeAlgorithm
3 participants