Provide details on how to fix error when ww schema is broken#2466
Merged
freddyaboulton merged 4 commits intomainfrom Jul 7, 2021
Merged
Provide details on how to fix error when ww schema is broken#2466freddyaboulton merged 4 commits intomainfrom
freddyaboulton merged 4 commits intomainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2466 +/- ##
=======================================
+ Coverage 99.7% 99.7% +0.1%
=======================================
Files 283 283
Lines 25566 25577 +11
=======================================
+ Hits 25464 25475 +11
Misses 102 102
Continue to review full report at Codecov.
|
bchen1116
approved these changes
Jul 6, 2021
Contributor
bchen1116
left a comment
There was a problem hiding this comment.
Nice fix! The message is clear!
angela97lin
approved these changes
Jul 6, 2021
Contributor
angela97lin
left a comment
There was a problem hiding this comment.
LGTM, thanks for doing this! 😁
a65be86 to
0314145
Compare
08a1084 to
dd87381
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fixes #2353
This is the new stacktrace:
After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of
docs/source/release_notes.rstto include this pull request by adding :pr:123.