Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade XGBoost to >=1.4.0 #2484

Merged
merged 4 commits into from
Jul 12, 2021
Merged

Upgrade XGBoost to >=1.4.0 #2484

merged 4 commits into from
Jul 12, 2021

Conversation

angela97lin
Copy link
Contributor

Closes #1536

@codecov
Copy link

codecov bot commented Jul 9, 2021

Codecov Report

Merging #2484 (2e9367b) into main (bd6bae6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2484   +/-   ##
=====================================
  Coverage   99.7%   99.7%           
=====================================
  Files        283     283           
  Lines      25585   25585           
=====================================
  Hits       25483   25483           
  Misses       102     102           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd6bae6...2e9367b. Read the comment docs.

@angela97lin angela97lin changed the title Upgrade XGBoost to >1.4.0 Upgrade XGBoost to >=1.4.0 Jul 9, 2021
@angela97lin angela97lin marked this pull request as ready for review July 9, 2021 19:16
Copy link
Contributor

@bchen1116 bchen1116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for walking it through during OH!

Copy link
Contributor

@chukarsten chukarsten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will probably have to be updated to >1.4.2 after XGBoost releases again, per all the junk having to do with incompatibility between XGBoost < 1.4.2 and pandas 1.3.0.

@angela97lin angela97lin merged commit 7463475 into main Jul 12, 2021
@angela97lin angela97lin deleted the xgboost_1.4.0 branch July 12, 2021 14:50
@chukarsten chukarsten mentioned this pull request Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unpin XGBoost Version upon XGBoost package update
3 participants