-
Notifications
You must be signed in to change notification settings - Fork 89
fixing sphinx / rtd warnings from sklearn #249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #249 +/- ##
======================================
Coverage 97.3% 97.3%
======================================
Files 95 95
Lines 2712 2712
======================================
Hits 2639 2639
Misses 73 73
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one comment. otherwise, can you also just activate this version on RTD so we can verify it worked?
Gotcha, already running on RTD now and just waiting :) |
@kmax12 Looks okay to me, let me know what you think! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #248
Note:
Introduces the following warning from Sphinx:
Looked into it and it seems like this is fixed but has not been released yet (tested with
-e git+https://github.com/readthedocs/sphinx_rtd_theme.git@ab7d388448258a24f8f4fa96dccb69d24f571736#egg=sphinx_rtd_theme
). Doesn't seem to affect functionality, so shouldn't be much of a concern?Linking this for reference.