Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing sphinx / rtd warnings from sklearn #249

Merged
merged 4 commits into from Dec 6, 2019
Merged

Conversation

angela97lin
Copy link
Contributor

@angela97lin angela97lin commented Dec 5, 2019

Closes #248

Note:

Introduces the following warning from Sphinx:

writing additional pages... search/Users/angela.lin/Desktop/venv/lib/python3.7/site-packages/sphinx_rtd_theme/search.html:20: RemovedInSphinx30Warning:

To modify script_files in the theme is deprecated. Please insert a <script> tag directly in your theme instead.

Looked into it and it seems like this is fixed but has not been released yet (tested with -e git+https://github.com/readthedocs/sphinx_rtd_theme.git@ab7d388448258a24f8f4fa96dccb69d24f571736#egg=sphinx_rtd_theme). Doesn't seem to affect functionality, so shouldn't be much of a concern?

Linking this for reference.

@codecov
Copy link

codecov bot commented Dec 5, 2019

Codecov Report

Merging #249 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #249   +/-   ##
======================================
  Coverage    97.3%   97.3%           
======================================
  Files          95      95           
  Lines        2712    2712           
======================================
  Hits         2639    2639           
  Misses         73      73
Impacted Files Coverage Δ
evalml/models/auto_classifier.py 100% <100%> (ø) ⬆️
evalml/__init__.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e006916...9f63cf3. Read the comment docs.

@angela97lin angela97lin self-assigned this Dec 5, 2019
requirements.txt Outdated Show resolved Hide resolved
Copy link
Contributor

@kmax12 kmax12 left a comment

one comment. otherwise, can you also just activate this version on RTD so we can verify it worked?

requirements.txt Outdated Show resolved Hide resolved
@angela97lin
Copy link
Contributor Author

angela97lin commented Dec 5, 2019

Gotcha, already running on RTD now and just waiting :)

@angela97lin
Copy link
Contributor Author

angela97lin commented Dec 5, 2019

@kmax12 Looks okay to me, let me know what you think!
https://evalml.featurelabs.com/en/rand_warning/index.html

@angela97lin angela97lin requested a review from kmax12 Dec 6, 2019
kmax12
kmax12 approved these changes Dec 6, 2019
Copy link
Contributor

@kmax12 kmax12 left a comment

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle or suppress FutureWarnings from sklearn
2 participants