Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade XGBoost requirement to >=1.4.2 #2498

Merged
merged 10 commits into from
Jul 14, 2021
Merged

Upgrade XGBoost requirement to >=1.4.2 #2498

merged 10 commits into from
Jul 14, 2021

Conversation

angela97lin
Copy link
Contributor

Closes #2497

I noticed the error disappeared with 1.4.2. Digging further: https://stackoverflow.com/questions/67095097/xgboosterror-check-failed-typestr-size-3-2-vs-3-typestr-should-be, the fix was added in 1.4.2: dmlc/xgboost#6927

@codecov
Copy link

codecov bot commented Jul 12, 2021

Codecov Report

Merging #2498 (8134c7a) into main (e929f22) will not change coverage.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2498   +/-   ##
=====================================
  Coverage   99.7%   99.7%           
=====================================
  Files        283     283           
  Lines      25585   25585           
=====================================
  Hits       25483   25483           
  Misses       102     102           
Impacted Files Coverage Δ
.../automl_tests/test_automl_search_classification.py 100.0% <100.0%> (ø)
...ests/automl_tests/test_automl_search_regression.py 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e929f22...8134c7a. Read the comment docs.

@@ -241,11 +241,11 @@ def test_categorical_classification(X_y_categorical_classification):
y_train=y,
problem_type="binary",
objective="precision",
max_iterations=5,
max_batches=1,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating this test to max_batches = 1, and then checking that none of the cv scores is None. This way, XGBoost is run and if the cv score is none (aka xgboost errors), we catch it here! Run with XGBoost == 1.4.0 to see an error :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So with this change, this test would fail on main right now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@freddyaboulton With this change and xgboost == 1.4.0, this would fail. However, since we don't cap XGBoost, we install >=1.4.2 which passes :)

@angela97lin angela97lin marked this pull request as ready for review July 13, 2021 20:54
Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks @angela97lin

@angela97lin angela97lin merged commit e30c30c into main Jul 14, 2021
@angela97lin angela97lin deleted the xgboost_1.4.2 branch July 14, 2021 20:13
@angela97lin angela97lin self-assigned this Jul 15, 2021
@chukarsten chukarsten mentioned this pull request Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

XGBoost error with running v1.4.0
2 participants