-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade XGBoost requirement to >=1.4.2 #2498
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2498 +/- ##
=====================================
Coverage 99.7% 99.7%
=====================================
Files 283 283
Lines 25585 25585
=====================================
Hits 25483 25483
Misses 102 102
Continue to review full report at Codecov.
|
@@ -241,11 +241,11 @@ def test_categorical_classification(X_y_categorical_classification): | |||
y_train=y, | |||
problem_type="binary", | |||
objective="precision", | |||
max_iterations=5, | |||
max_batches=1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updating this test to max_batches = 1, and then checking that none of the cv scores is None. This way, XGBoost is run and if the cv score is none (aka xgboost errors), we catch it here! Run with XGBoost == 1.4.0 to see an error :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So with this change, this test would fail on main right now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@freddyaboulton With this change and xgboost == 1.4.0, this would fail. However, since we don't cap XGBoost, we install >=1.4.2 which passes :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks @angela97lin
Closes #2497
I noticed the error disappeared with 1.4.2. Digging further: https://stackoverflow.com/questions/67095097/xgboosterror-check-failed-typestr-size-3-2-vs-3-typestr-should-be, the fix was added in 1.4.2: dmlc/xgboost#6927