Test that all pipelines get the same data splits#2513
Merged
freddyaboulton merged 3 commits intomainfrom Jul 19, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2513 +/- ##
=======================================
+ Coverage 99.7% 99.7% +0.1%
=======================================
Files 283 283
Lines 25674 25709 +35
=======================================
+ Hits 25573 25608 +35
Misses 101 101
Continue to review full report at Codecov.
|
freddyaboulton
commented
Jul 14, 2021
| ProblemTypes.TIME_SERIES_MULTICLASS, | ||
| ], | ||
| ) | ||
| def test_data_splitter_gives_pipelines_same_data( |
Contributor
Author
freddyaboulton
requested review from
ParthivNaresh,
angela97lin,
bchen1116,
christopherbunn,
chukarsten,
dsherry and
jeremyliweishih
freddyaboulton
force-pushed
the
1982-test-all-pipelines-get-the-same-splits
branch
from
65b4711 to
b6bdf5d
Compare
bchen1116
approved these changes
Jul 14, 2021
Contributor
bchen1116
left a comment
bchen1116
left a comment
There was a problem hiding this comment.
Looks good! Nice test coverage!
|
|
||
| # current automl algo trains each pipeline using 3-fold CV for "small" datasets (i.e. test data above) | ||
| # therefore, each pipeline should recieve an identical set of three training-validation splits | ||
| X_fit_hashes, y_fit_hashes = defaultdict(set), defaultdict(set) |
chukarsten
approved these changes
Jul 15, 2021
Contributor
chukarsten
left a comment
chukarsten
left a comment
There was a problem hiding this comment.
That was a super big brained move with the hashes and the assertion. It took me longer than I care to admit to understand how this worked, lol.
| ) | ||
| n_splits = automl.data_splitter.n_splits | ||
| env = AutoMLTestEnv(automl_type) | ||
| with env.test_context(score_return_value={automl.objective.name: 1.0}): |
Contributor
There was a problem hiding this comment.
Drinking your own koolaid. respect
angela97lin
approved these changes
Jul 15, 2021
Contributor
angela97lin
left a comment
angela97lin
left a comment
There was a problem hiding this comment.
Love this addition, LGTM 👍
freddyaboulton
force-pushed
the
1982-test-all-pipelines-get-the-same-splits
branch
from
b6bdf5d to
6d62b02
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fixes #1982
After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of
docs/source/release_notes.rstto include this pull request by adding :pr:123.