Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove shellcheck from build_conda_pkg #2514

Merged
merged 5 commits into from
Jul 15, 2021
Merged

Conversation

freddyaboulton
Copy link
Contributor

@freddyaboulton freddyaboulton commented Jul 14, 2021

Pull Request Description

Fixes #2400

The minimum dependency tests were not running shellcheck - it was build_conda_pkg that was reporting the results of shellcheck along the minimum dependency tests. See this pr https://github.com/alteryx/evalml/pull/2488/checks that doesn't run build_conda_pkg and shellcheck does not show up anywhere.

I think we should remove shellcheck. The first commit ran build_conda_pkg without shellcheck and it passed.


After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of docs/source/release_notes.rst to include this pull request by adding :pr:123.

@codecov
Copy link

codecov bot commented Jul 14, 2021

Codecov Report

Merging #2514 (f7c9455) into main (0bb0f55) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2514   +/-   ##
=====================================
  Coverage   99.7%   99.7%           
=====================================
  Files        283     283           
  Lines      25674   25674           
=====================================
  Hits       25573   25573           
  Misses       101     101           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bb0f55...f7c9455. Read the comment docs.

Copy link
Collaborator

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

Copy link
Contributor

@angela97lin angela97lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1!

@chukarsten chukarsten merged commit 1cd2d77 into main Jul 15, 2021
@freddyaboulton freddyaboulton deleted the 2400-remove-shellcheck branch July 15, 2021 14:44
@chukarsten chukarsten mentioned this pull request Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PR CI: unit test shellcheck
4 participants