Remove shellcheck from build_conda_pkg #2514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2514 +/- ##
=====================================
Coverage 99.7% 99.7%
=====================================
Files 283 283
Lines 25674 25674
=====================================
Hits 25573 25573
Misses 101 101 Continue to review full report at Codecov.
|
freddyaboulton
requested review from
ParthivNaresh,
angela97lin,
bchen1116,
christopherbunn,
chukarsten,
dsherry and
jeremyliweishih
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fixes #2400
The minimum dependency tests were not running
shellcheck- it wasbuild_conda_pkgthat was reporting the results ofshellcheckalong the minimum dependency tests. See this pr https://github.com/alteryx/evalml/pull/2488/checks that doesn't runbuild_conda_pkgandshellcheckdoes not show up anywhere.I think we should remove shellcheck. The first commit ran
build_conda_pkgwithout shellcheck and it passed.After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of
docs/source/release_notes.rstto include this pull request by adding :pr:123.