Fix the windows 3.7 nightlies #2516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2516 +/- ##
=====================================
Coverage 99.7% 99.7%
=====================================
Files 283 283
Lines 25674 25674
=====================================
Hits 25573 25573
Misses 101 101 Continue to review full report at Codecov.
|
freddyaboulton
requested review from
dsherry,
angela97lin,
bchen1116,
chukarsten,
jeremyliweishih and
ParthivNaresh
angela97lin
approved these changes
Jul 15, 2021
bchen1116
approved these changes
Jul 15, 2021
| @@ -6,7 +6,7 @@ xgboost>=1.4.2 | |||
| catboost>=0.20 | |||
| lightgbm>=2.3.1 | |||
| matplotlib>=3.3.3 | |||
| graphviz>=0.13 | |||
| graphviz>=0.13;platform_system!='Windows' | |||
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fix the windows 3.7 nightlies
Our windows ci installs graphviz with conda and then with pip when we run
pip install .If you look at a successful 3.7 run from before last night, you should see
Requirement already satisfied: graphviz>=0.13 in c:\users\runneradmin\miniconda3\envs\curr_py\lib\site-packages (from evalml==0.28.0) (0.16)If you look at the run that failed last night, you will see:
Collecting graphviz>=0.13 Downloading graphviz-0.17-py3-none-any.whl (18 kB).So for some reason, the pip version is starting to override the conda version. This only happens for 3.7! The logs for the successful 3.8 runs from last night say
Requirement already satisfied: graphviz>=0.13 in c:\users\runneradmin\miniconda3\envs\curr_py\lib\site-packages (from evalml==0.28.0) (0.16)Not exactly sure why this is happening, but since conda is able to successfully install graphviz in a way that makes our unit tests pass I think we can avoid the problem if we skip the pip install for windows.
Our docs already tell users to install graphviz with windows so I think we're covered there.
After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of
docs/source/release_notes.rstto include this pull request by adding :pr:123.