Condense log statements in build_conda_pkg#2521
Merged
freddyaboulton merged 6 commits intomainfrom Jul 20, 2021
Merged
Conversation
freddyaboulton
changed the title
Codecov Report
@@ Coverage Diff @@
## main #2521 +/- ##
=====================================
Coverage 99.7% 99.7%
=====================================
Files 283 283
Lines 25808 25808
=====================================
Hits 25707 25707
Misses 101 101
Continue to review full report at Codecov.
|
freddyaboulton
commented
Jul 19, 2021
|
|
||
|
|
||
| class TestPipelineWithFitError(BinaryClassificationPipeline): | ||
| class DaskPipelineWithFitError(BinaryClassificationPipeline): |
Contributor
Author
There was a problem hiding this comment.
So that pytest doesn't think these are test cases and issue warnings
freddyaboulton
requested review from
ParthivNaresh,
angela97lin,
bchen1116,
christopherbunn,
chukarsten,
dsherry,
eccabay and
jeremyliweishih
freddyaboulton
changed the title
freddyaboulton
force-pushed
the
2321-fix-log-statements
branch
from
15daf58 to
4673c24
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fixes #2321
Fixes #2322
The fix is to upgrade the version of pytest in the conda build (this will avoid printing duplicate warnings on separate lines) and fix some of our code to avoid warnings. We can't get rid of all the warnings because some of them are coming from third party libraries. These are all the warnings written to log now - I think it's better now and there's much less scrolling.
After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of
docs/source/release_notes.rstto include this pull request by adding :pr:123.